Closed
Bug 962786
Opened 11 years ago
Closed 11 years ago
Convert nsDragService to use Moz2D
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mattwoodrow, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 8 obsolete files)
|
34.08 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The nsDragService implementations currently use gfxASurface's for drawing the drag image. We should convert this to use SourceSurface instead.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8364110 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8364111 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8364112 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8364113 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Attachment #8364114 -
Flags: review?(roc)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #8364115 -
Flags: review?(roc)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Attachment #8364116 -
Flags: review?(roc)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #8364118 -
Flags: review?(roc)
|
|
Assignee | |
Comment 9•11 years ago
|
||
I probably should have just done this all as a single change, ended up being simpler that I expected.
Yeah. Do you want to just fold all these together and have me review the combined patch? I think that will make the changes more obvious.
|
|
Assignee | |
Comment 11•11 years ago
|
||
Goodbye pointlessly large patch queue.
Attachment #8364110 -
Attachment is obsolete: true
Attachment #8364111 -
Attachment is obsolete: true
Attachment #8364112 -
Attachment is obsolete: true
Attachment #8364113 -
Attachment is obsolete: true
Attachment #8364114 -
Attachment is obsolete: true
Attachment #8364115 -
Attachment is obsolete: true
Attachment #8364116 -
Attachment is obsolete: true
Attachment #8364118 -
Attachment is obsolete: true
Attachment #8364110 -
Flags: review?(roc)
Attachment #8364111 -
Flags: review?(roc)
Attachment #8364112 -
Flags: review?(roc)
Attachment #8364113 -
Flags: review?(roc)
Attachment #8364114 -
Flags: review?(roc)
Attachment #8364115 -
Flags: review?(roc)
Attachment #8364116 -
Flags: review?(roc)
Attachment #8364118 -
Flags: review?(roc)
Attachment #8365724 -
Flags: review?(roc)
Comment on attachment 8365724 [details] [diff] [review]
Convert nsDragService
Review of attachment 8365724 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/nsIPresShell.h
@@ +1037,5 @@
> + virtual mozilla::TemporaryRef<mozilla::gfx::SourceSurface>
> + RenderNode(nsIDOMNode* aNode,
> + nsIntRegion* aRegion,
> + nsIntPoint& aPoint,
> + nsIntRect* aScreenRect) = 0;
Add typedefs for TemporaryRef and SourceSurface to this class to avoid prefixes
::: widget/xpwidgets/nsBaseDragService.h
@@ +83,5 @@
> nsresult DrawDrag(nsIDOMNode* aDOMNode,
> nsIScriptableRegion* aRegion,
> int32_t aScreenX, int32_t aScreenY,
> nsIntRect* aScreenDragRect,
> + mozilla::RefPtr<mozilla::gfx::SourceSurface>* aSurface,
add a typedef for RefPtr and SourceSurface to this class to avoid this prefix madness
Attachment #8365724 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 13•11 years ago
|
||
|
|
Assignee | |
Comment 14•11 years ago
|
||
|
||
Comment 15•11 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/91dd7ce4cfaf for content/svg/content/test/test_text_selection.html bustage like https://tbpl.mozilla.org/php/getParsedLog.php?id=33717670&tree=Mozilla-Inbound
|
||
Comment 16•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•