962808 - [Session Restore] Better telemetry for _writeState

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Telemetry for _writeState

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8364232 [details] [diff] [review]
Telemetry for _writeState

Review of attachment 8364232 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/SessionSaver.jsm
@@ +294,5 @@
>      data = this._notifyObserversBeforeStateWrite(data);
>  
>      // Don't touch the file if an observer has deleted all state data.
>      if (!data) {
> +      stopWatchFinish("WRITE_STATE_LONGEST_OP_MS");

Don't we rather want to cancel here if any weird add-on decides to block sessionstore from writing data?

@@ +307,5 @@
>  
>      // Write (atomically) to a session file, using a tmp file. Once the session
>      // file is successfully updated, save the time stamp of the last save and
>      // notify the observers.
> +    stopWatchStart("WRITE_SERIALIZED_STATE_LONGEST_OP_MS");

I don't particularly like that name because it doesn't really convey what it's measuring. Maybe something that mentions communication? Sending it to the worker?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Telemetry for _writeState, v2

Applied feedback.
Try https://tbpl.mozilla.org/?tree=Try&rev=8b1085ce82ba

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6febd7a30de3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for mochitest-bc failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6dc7e3ae7c

https://tbpl.mozilla.org/php/getParsedLog.php?id=33535456&tree=Mozilla-Inbound

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Windows-only.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Telemetry for _writeState, v3

Arf, added missing |return|. For once, the unsufferable Windows file protection has found a use.
https://tbpl.mozilla.org/?tree=Try&rev=34ed071dfba8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/ecd9c9d60698

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ecd9c9d60698