962969 - [email] build: make_gaia_shared.js should use source dir for shared dependency scanning

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

Now that email is using uglifyjs for minification, the make_shared_gaia.js script that looks for shared resources to include in the app dir, for dynamic loading, it will not find some constructs now inside a define()'d module, like:

    require(['a'], function() {})

because uglify mangles the file so the AST walking does not find the module API calls. It is better to use the source files for this walking, and it is also OK to use the source files for the digest creation as all changes are keyed off source file changes anyway.

Comment 1

[James Burke [:jrburke]]

Attachment: GitHub pull request

Uses srcDir instead of buildDir, and makes sure a shared resource is only added once to the shared.js array.

Context for reviewer: psingapati in irc found that doing a dynamic require call with uglify on for a shared resource no longer worked. It was because of the uglification mangling the AST such that the AST dependency scanning could not find the expected AMD API names.

Comment 2

[James Burke [:jrburke]]

Merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/b121168d733cbaac875d69612b3a47b35beaa30d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/15635

Does not affect 1.3, just a master, as only master has uglify minification enabled.