962987 - [tarako] Move screenshoting to before closing animation and use cache in cardview if there is

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect, P2)

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15712

Please try with this patch.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

After trying out the patch with Thinker, we have not found and visible performance gain.

Ting-Yu, please find Thinker and try to figure out the detail. Thanks!

Comment 3

[Ting-Yu Chou [:ting] (away)]

Confirmed with Tim and Lawrence the image was checked out and built today. I'll see what can I find from recent commits.

Comment 4

[Ting-Yu Chou [:ting] (away)]

Tim, I can't simply flash raw gaia v1.3 (from https://git.mozilla.org/releases/gaia.git) to Tarako, it complains the disk space is not enough. So I'd like to double confirm the steps you used for flashing gaia this morning.

# If the updating is failed, the screenshot will be kept disabled in windowClosed().
# There are three extra directories (gaia/customize_apps, gaia/local_mk, gaia/sprd_recource) from spreadtrum in my tree to drop unused applications.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please flash Gaia apps to /data/local partition by using the following command:

GAIA_INSTALL_PARENT=/data/local make install-gaia

To purge any Gaia files first, do

GAIA_INSTALL_PARENT=/data/local make reset-gaia

Append |APP=system | before the command will only push the app zip, and save some time.

The sprd* files are not related to this bug because they will not modify system app in any way.

Thanks!

Comment 6

[Ting-Yu Chou [:ting] (away)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)

I see, will try this after back from holiday.

> Please flash Gaia apps to /data/local partition by using the following
> command:
> 
> GAIA_INSTALL_PARENT=/data/local make install-gaia
> 
> To purge any Gaia files first, do
> 
> GAIA_INSTALL_PARENT=/data/local make reset-gaia
> 
> Append |APP=system | before the command will only push the app zip, and save
> some time.
> 
> The sprd* files are not related to this bug because they will not modify
> system app in any way.
> 
> Thanks!

Comment 7

[Ting-Yu Chou [:ting] (away)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> After trying out the patch with Thinker, we have not found and visible
> performance gain.
> 
> Ting-Yu, please find Thinker and try to figure out the detail. Thanks!

Tested on Tarako to figure out why Tim could not reproduce the high sys loading
when back to home screen (screenshot is taken in windowClosed()):

gaia (system app)
- 22bc6be5
  The launched app has chances to survive for more than 3 seconds (13/20) after
  back to home screen:
    5/13: sys loading is high during the period and drops after it is killed
    8/13: sys loading keeps low
- b0aa7461
  The launched app is killed (20/20) right after back to homescreen.

# gecko = cd8bc54e
# Usage is not running.
# Number of major page faults goes up to over 100/second when sys loading is high.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

mark 1.3T?

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: not needed for tarako at this moment

Comment 10

[Ting-Yu Chou [:ting] (away)]

kernel = 5727a193
gecko  = 6ae23596
gaia   = 19a5035b

Based on the code above, I couldn't see high system loading from taking a screenshot while switching from app to home screen. Do we still need the patch (attachment 8365829 [details] [review]) which moves screenshot taking from windowClosed() to closeWindow()?

# bug 963268 changed screenshot to a software canvas.

Comment 11

[Andreas Gal :gal]

I think we can close this for now. We are no longer instantiating the GL stack in the content process which caused the high load and GPU contention.