Closed Bug 963009 Opened 10 years ago Closed 10 years ago

[Gaia][Build] Test coverage

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gduan, Assigned: rickychien)

References

Details

Attachments

(3 files, 2 obsolete files)

We should have a test coverage report for build script.
I have tried blanket for it, however, there're some troubles
1. Unknown Error code 6 8 1, when requiring install-gaia.js
2. blanket seems to have ability to run |require| code inside script, however, we've used a lot of proxyquire module to replace require. So the test result doesn't actually run the target script.
3. I tried to insert a "data-cover-adapter" inside config, but it doesn't work.
Attached file PR to master (obsolete) —
istanbul is more easy to integrate with our current test scripts.
However, it doesn't support harmony mode, like let and const.
Attached file coverage.zip
Attach the test report.
Attached image screenshot of console output (obsolete) —
Screenshot of the console
Assignee: nobody → gduan
As the author commented in https://github.com/gotwarlost/istanbul/issues/141, we probably need another repo for it.
Update report.
Attachment #8364854 - Attachment is obsolete: true
Move the test coverage to v1.5.
Blocks: 2.0-system-platform
No longer blocks: 1.4-system-platform
Status: NEW → ASSIGNED
What's the status of this bug? Is this already done elsewhere?
Flags: needinfo?(yurenju)
The problems we had on istanbul:
1. Istanbul didn't support ES6 ( I only tested on those without ES6 script.)
2. its harmony mode still not work.
3. It takes time to study the source code, so I didn't move it on.

We can put it in Build plan.
It seems Ricky has a solution for it.
assign to Ricky.
Assignee: gduan → ricky060709
Thanks George & Ricky :-)
Flags: needinfo?(yurenju)
Linter test fail has been fixed. Here new try server status:

https://tbpl.mozilla.org/?rev=298f1eade8137cc6a5bd6193e787a2e249eb7e3a&tree=Gaia-Try
Attachment #8364852 - Attachment is obsolete: true
Attachment #8364852 - Flags: review?(yurenju)
Attached file Gaia PR
Update attachment
Attachment #8494980 - Flags: review?(yurenju)
Comment on attachment 8494980 [details] [review]
Gaia PR

Ricky, this feature is awesome! please fix nits, rebase and wait all tasks are green on try server.
Attachment #8494980 - Flags: review?(yurenju) → review+
Merged.

https://github.com/mozilla-b2g/gaia/commit/931d547dbd2f4664b6a3c1ff5e4244bca52f96ad
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: