963009 - [Gaia][Build] Test coverage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

We should have a test coverage report for build script.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

I have tried blanket for it, however, there're some troubles
1. Unknown Error code 6 8 1, when requiring install-gaia.js
2. blanket seems to have ability to run |require| code inside script, however, we've used a lot of proxyquire module to replace require. So the test result doesn't actually run the target script.
3. I tried to insert a "data-cover-adapter" inside config, but it doesn't work.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

istanbul is more easy to integrate with our current test scripts.
However, it doesn't support harmony mode, like let and const.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: coverage.zip

Attach the test report.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: screenshot of console output

Screenshot of the console

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

https://github.com/gotwarlost/istanbul/issues/141

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

As the author commented in https://github.com/gotwarlost/istanbul/issues/141, we probably need another repo for it.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: screenshot of console output

Update report.

Comment 8

[Ivan Tsay (:ITsay)]

Move the test coverage to v1.5.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

What's the status of this bug? Is this already done elsewhere?

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

The problems we had on istanbul:
1. Istanbul didn't support ES6 ( I only tested on those without ES6 script.)
2. its harmony mode still not work.
3. It takes time to study the source code, so I didn't move it on.

We can put it in Build plan.

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

It seems Ricky has a solution for it.
assign to Ricky.

Comment 12

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Thanks George & Ricky :-)

Comment 13

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8364852 [details] [review]
PR to master

https://github.com/mozilla-b2g/gaia/pull/24276

Comment 14

[Ricky Chien [:rickychien] (inactive)]

Try server:

https://tbpl.mozilla.org/?rev=dbd19295cdb354bd84e3c33e7de835473f142741&tree=Gaia-Try

Comment 15

[Ricky Chien [:rickychien] (inactive)]

Linter test fail has been fixed. Here new try server status:

https://tbpl.mozilla.org/?rev=298f1eade8137cc6a5bd6193e787a2e249eb7e3a&tree=Gaia-Try

Comment 16

[Ricky Chien [:rickychien] (inactive)]

Updated try server status:

https://tbpl.mozilla.org/?rev=860284befb77697bb906b73ae3d5567ca54600fa&tree=Gaia-Try

Comment 17

[Ricky Chien [:rickychien] (inactive)]

Attachment: Gaia PR

Update attachment

Comment 18

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8494980 [details] [review]
Gaia PR

Ricky, this feature is awesome! please fix nits, rebase and wait all tasks are green on try server.

Comment 19

[Ricky Chien [:rickychien] (inactive)]

Merged.

https://github.com/mozilla-b2g/gaia/commit/931d547dbd2f4664b6a3c1ff5e4244bca52f96ad