963010 - [NFC] When shrinking UI showed up, it will be strange when clicked on home button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Walter Chen[:ypwalter][:wachen]]

most up-to-date pvt build 1/23 for mako

STR:
1. launch "settings" app for 2 phones
2. turn on "NFC" for 2 phones
3. launch "browser" for 2 phones
4. press on "home button" for one of the phone

expected result:
NFC disconnected and it went back to homescreen

actual result:
NFC pairing is not disconnected, and it went back to homescreen with black shrinking UI on the background

Comment 1

[Walter Chen[:ypwalter][:wachen]]

STR:
1. launch "settings" app for 2 phones
2. turn on "NFC" for 2 phones
3. launch "browser" for 2 phones
4. tap the phone together
5. press on "home button" for one of the phone

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

If the expected result is per UX defined, we should nominate it as 1.4?

Comment 3

[Walter Chen[:ypwalter][:wachen]]

This is very bad behavior, and there is no UX definition for it.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

needinfo UX for input

Comment 5

[Juwei Huang[:juwei]]

I've discussed with Alive before, the home button should be block all the time in this situation.
Tapping on home button or long pressing home button should be no function at all when NFC connected.
So the correct UX should be:
1. Turn on NFC for both phones
2. Turn on browser
3. Tap the phone together, UI shrink
4. Tap on home button, no function. Keep shrinking browser UI

Comment 6

[Walter Chen[:ypwalter][:wachen]]

Is there any documentation on this discussed behavior? If no, please add it to shrinking UI UX document please.

Comment 7

[Juwei Huang[:juwei]]

Sure!
I've updated spec to bug 920882

Comment 8

[Walter Chen[:ypwalter][:wachen]]

Juwei, Thanks for the update!

Wesley,
Please make this 1.4+ since it is bad behavior that is totally different from UX spec.

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Ok to set 1.4+, based on page#10 of the UX doc.
https://bug920882.bugzilla.mozilla.org/attachment.cgi?id=8372588

Comment 10

[Kai-Chih Hu [:khu]]

Can we find someone to help this bug? Thank you.

Comment 11

[Ken Chang[:kenkai]]

Greg, can you please take this bug? It is related to shrinking UI.

Comment 12

[Walter Chen[:ypwalter][:wachen]]

Any one who works on this, please do refer to comment 5 for UX design. Also, https://bugzilla.mozilla.org/attachment.cgi?id=811878 UX design is for your reference.

If there is any UX issues, please discuss with us.

Thanks.

Comment 13

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll survey how to disable these interruptions during NFC sharing.
But I doubt that we may need to do some trick to achieve that.

Comment 14

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Mimic the behavior that LockScreen does to block the home key function during NFC sharing.

Comment 15

[Jason Smith [:jsmith]]

No longer going to block - NFC needs to be preffed off in 1.4 per a drivers decision to cut scope to only DSDS & QC required features.

Comment 16

[Walter Chen[:ypwalter][:wachen]]

sorry, wrong triggered a change :P

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8379411 [details] [review]
Patch

Strongly recommand to have unit test for state control.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/f903eb45eed032a585ec3d4faac7fa38bf958ce8