963037 - [FTE] When I insert three times invalid PIN I can't see PUK1 screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Maria Angeles Oteo (:oteo)]

Pre-requisites:
SIM with active PIN without entering the PIN before
Opening this bug as suggested in comment 11 in Bug 961746

Steps:
1. Lanch FTE
2. Insert three times an invalid PIN

Expect result:
See PUK screen

Actual result:
PUK screen is not shown, you can enter more than 3 times the incorrect PIN

Comment 1

[Maria Angeles Oteo (:oteo)]

buri
v1.3
B-44
Gecko-086e699
Gaia-6fbeac2

Comment 2

[Andrew Overholt [:overholt]]

Dupe of a blocker.

Comment 3

[Maria Angeles Oteo (:oteo)]

(In reply to Andrew Overholt [:overholt] from comment #2)
> Dupe of a blocker.
> 
> *** This bug has been marked as a duplicate of bug 961746 ***

Hi Andrew,
I created this bug becuse Arthur told me in bug 961746 (the one marked as duplicated) that FTE handles sim card lock by itself and suggested me to open a new bug reporting the fault in the FTE. 
Requesting ni to Andrew to confirm it

Comment 4

[Jason Smith [:jsmith]]

Okay - I saw the comment in the other bug. The implementation work would be different here than bug 961746, so I'll reopen to track a fix in the FTE app.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Repro verified on master. Looks like we never actually check to see what the card state is after pin entry failures.

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - When PIN retries hits 0 in FTU, bring up PUK screen

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

It seems like it'd be better to see if cardState flipped from pinRequired to pukRequired, but that doesn't seem to be happening when I check mozIcc.cardState. So, we just watch for the retries to hit 0.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #7)
> It seems like it'd be better to see if cardState flipped from pinRequired to
> pukRequired, but that doesn't seem to be happening when I check
> mozIcc.cardState. So, we just watch for the retries to hit 0.

Yeah, the card state update is not immediate. That's why we have to do this when unlocking:
https://github.com/mozilla-b2g/gaia/blob/6b5ab7b303747c6356c71a4e0fbeba6ec0cb7471/apps/communications/ftu/js/sim_manager.js#L559

Comment 9

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://github.com/qdot/gaia/commit/fbe5fb9710530d2d540d626852b6599387ec53a4

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted fbe5fb9710530d2d540d626852b6599387ec53a4 to:
v1.3: 8dcbb45aeb6378391ac779fe82f1bc2d9af4eefd

Comment 11

[Loli (:lolimartinezcr)]

Tested (02/03/2014) and working
1.3
Gecko 3c269ae
Gaia f9a37c7