963096 - Caps lock is switched on when quickly tapping shift before and after another key

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Found in automation when typing two uppercase letters, but reproduced manually.

Steps to reproduce:
1. Open an app with a keyboard (such as Browser)
2. Make sure caps lock is off
3. Quickly tap [shift], [letter], [shift]

Expected:
Caps lock is not enabled

Actual:
Caps lock is enabled

I also noticed that it's possible to type several uppercase letters after tapping shift, if you're fast enough.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This is old but a valid bug.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This bug is trivial to implement with the current business logic handling. We can simply remove doubleTapTimers of every other targets when a target is activated, in activeTargetManager. Rudy, would you like to implement this?

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Take it.
Thanks.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8514924 [details] [review]
Patch V1

Tim, could you help review this?
Thanks.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8514924 [details] [review]
Patch V1

Given the fact we actually never remove any DOM element for now, it make sense to remove the WeakMap instance. But I think we should flatten the information with 

this.doubleTapTimer
this.doubleTapPreviousTarget

So we don't create a new dict, which can be abused in the future code additions.

Alternatively, bringing back the WeakMap is actually cleaner in terms of code pattern (although redundant).

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8514924 [details] [review]
Patch V1

Thanks for the feedback.
I'll take the first approach as you suggested, please help review it again?

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

master,
https://github.com/mozilla-b2g/gaia/commit/53259ae67e3966ead5786619f913575eb7cf7b13

--
Thanks for the review.