963167 - JS_SetElement() should take HandleValue rather than MutableHandleValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

As was done for the JS_SetProperty() APIs in bug 896949, we should be taking HandleValue for the element value here rather than MutableHandleValue.

Comment 1

[Jon Coppeard (:jonco)]

Not only that, it would be helpful to overload it as is being done for JS_DefineProperty() in bug 959787 so that we can pass different types without having to root a value every time.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: set-element-js

Patch for changes under js/src

Comment 3

[Jon Coppeard (:jonco)]

Attachment: set-element-browser

Patch for changes to the rest of the browser

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8365137 [details] [diff] [review]
set-element-browser

>-    pairVal = JS::ObjectValue(*pair);

pairVal is now unused. Kill it off?

The vast majority of these callers should be using JS_DefineElement.  :(  Maybe file a followup bug to fix them up?

r=me

Comment 5

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f613b4ac27f9

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f613b4ac27f9