963248 - Warn admin when snippet or icon size is over a certain threshold

Status: VERIFIED FIXED

(Snippets :: Service, defect)

Description

[Osmose [:osmose, :mkelly]]

Twice now we've had major service issues related to large snippet filesizes (see bug 962885 as the most recent example).

The service should warn the admin if they create a snippet larger than the recommended file size. For snippet icons (or, more generally, any file field for a template), I think 300kb is a good upper limit, and 500kb for the entire snippet (we can tweak these if we want, we may want to go lower based on average snippet sizes).

The system should warn admins whenever they save a template or snippet that exceeds these limits in either one of their template variables or as the snippet on a whole, and allow the admin to either abort the operation or continue past the warning, in case we need to bypass the limit for a special case.

If we can check this on the JS side, an alert box on save would be fine for this.

Comment 1

[Kristján Oddsson [:koddsson]]

Attachment: PR to fix this bug

My stab at fixing this bug.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/snippets-service

https://github.com/mozilla/snippets-service/commit/4e77df9f877237a2307bb2200f50a75b2fe127c5
Fix bug 963248: Add size validation to snippet admin.

Comment 3

[Osmose [:osmose, :mkelly]]

Verified fixed on stage and has been deployed to prod. Yay!

Comment 4

[Kristján Oddsson [:koddsson]]

Awesome! :)