963292 - Change the edge gesture detector to works with APZC

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Since fixing mozbrowser.sendTouchEvent API for beeing compatible with APZC means touchmove events will not be dispatched anymore to the system app if we start forwarding the Gaia code needs some tweaks.

The order of events between mouse/touch is also a bit weird. Worth fixing it.

Comment 1

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR

Here it is!

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8366023 [details] [review]
Pointer to gaia PR

r+ with nits.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 8366023 [details] [review]
Pointer to gaia PR

After talking about this offline.

New r? for sending mouse events only in non-apzc cases.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8366023 [details] [review]
Pointer to gaia PR

Some nits and I would like to see a new version mostly because of the change I'm doing in bug 964904. (sorry i did it just after our discussion when you leaved the office).

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8366023 [details] [review]
Pointer to gaia PR

third time's the charm? :)

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8366023 [details] [review]
Pointer to gaia PR

r+ with 2 small typo nits.

Comment 8

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/d7af41b0d9ae3b6665c7cd714c30b8bc17a319e3

\o/