Closed Bug 963308 Opened 11 years ago Closed 7 years ago

header/body color does not match when waiting for the account to be setup

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: nhirata, Assigned: pivanov)

Details

Attachments

(4 files)

Attached image 2014-01-23-16-31-43.png
Gaia 6fbeac2415f07f10de181f0877ddf67ee299b885 Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/e8f6bdf8db3d BuildID 20140123004001 Version 28.0a2 ro.build.version.incremental=324 ro.build.date=Thu Dec 19 14:04:55 CST 2013 Buri 1. launch calendar 2. open drawer 3. click on + 4. select gmail 5. put in username/password 6. hit accept 7. look at the account setup screen carefully. Expected: header/background matches. Actual: color is slightly off.
Flags: needinfo?(epang)
Thanks Naoki, we should update this screen to match what is used in email. I'll attach a screenshot shortly. Pavel, can you help update this?
Assignee: nobody → pivanov
Flags: needinfo?(epang) → needinfo?(pivanov)
The setting up account screen should be the same in email and calendar.
Attached image After patch screenshot
Hey Kevin, one more from me. I'm just not sure about the l10n string, do I need to remove the old one?
Attachment #8368789 - Flags: review?(kgrandon)
Flags: needinfo?(pivanov)
Comment on attachment 8368789 [details] After patch screenshot This is just an image, and you probably want me to review some code? :)
Attachment #8368789 - Flags: review?(kgrandon)
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master
Hey Kevin ... sorry ... I was little distracted with the rocketbar :D
Attachment #8368869 - Flags: review?(kgrandon)
Flags: needinfo?(pivanov)
Comment on attachment 8368869 [details] [review] patch for Gaia/master Clearing review for now as it doesn't quite match up to Eric's spec and is slightly different than Email. The icon is left-aligned, and in Eric's screenshot it appears to be centered. Please update and will look again.
Attachment #8368869 - Flags: review?(kgrandon)
Comment on attachment 8368869 [details] [review] patch for Gaia/master Thanks Kevin, hope that it's OK now :)
Attachment #8368869 - Flags: review?(kgrandon)
Comment on attachment 8368869 [details] [review] patch for Gaia/master So unfortunately I have to R- this one for now. It looks like there's a new cancel button, but the cancel button doesn't actually work. We either need to make it work, or hide it. (It should probably work if we are changing to this dialog). We may need some resources from the productivity team to help here.
Attachment #8368869 - Flags: review?(kgrandon) → review-
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: