Closed
Bug 963326
Opened 10 years ago
Closed 10 years ago
[B2G][Clock] Delete button easily selectable while selecting word suggestions when editing an alarm
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(b2g-v1.2 affected, b2g-v1.3 affected)
VERIFIED
FIXED
1.4 S1 (14feb)
People
(Reporter: jschmitt, Assigned: mcav)
Details
(Keywords: regression, Whiteboard: dogfood1.3 [p=1])
Attachments
(2 files)
Description: The delete button can be pressed while changing the name of an alarm to a suggested word. Repro Steps: 1) Updated Buri to BuildID: 20140113004002 2) Proceed to the Clock app 3) Add a new alarm 4) Select the newly made alarm 5) Select the text field 6) Type 'hi' and select a suggested word Actual: The delete button can be pressed accidentally while selecting a suggested word Expected: The delete button not easily selectable. Environmental Variables: Device: Buri 1.3 MOZ BuildID: 20140121004137 Gaia: 47049555282a9a01fb60d1e1421b57e2810c96f5 Gecko: 6f7dfe36ab6c Version: 28.0a2 Firmware Version: V1.2-device.cfg Notes: Repro frequency: 100% See attached: Delete.mpeg
Reporter | ||
Comment 1•10 years ago
|
||
Issue also occurs on 1.2 Link to the video: www.youtube.com/watch?v=r3Fd1Dm43jg Environmental Variables Device: Buri v 1.2.0 COM RIL Build ID: 20140121004053 Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/c9f305c1d9a7 Gaia: 539a25e1887b902b8b25038c547048e691bd97f6 Platform Version: 26.0 RIL Version: 01.02.00.019.102 Firmware Version: v1.2-device.cfg
Comment 3•10 years ago
|
||
This issue does not repro on the Buri 1.1 Build ID: 20140123041201 Gaia c434fe9a0e823029796805e141cfa983cda2d246 SourceStamp aa0ceb07a73e BuildID 20140123041201 Version 18.0
Keywords: qawanted
QA Contact: sparsons
Comment 4•10 years ago
|
||
I find that the placement of the delete button in 1.1 and 1.2 makes it much harder to press the button by accident, although still probably possible. In 1.3 the design is noticeably different, the target for delete seems larger, and its placement is much closer to the auto correct suggestions, and can easily be hit by accident when trying to select a suggestion. It seems like a strange choice to me for the delete button to be displayed there at all when editing a text field in an already created alarm. From an end user standpoint I would rather the delete button remain at the bottom of the edit menu and hidden by the keyboard while editing a text field, so there was no chance of me deleting an alarm when I did not intend to.
Assignee | ||
Comment 6•10 years ago
|
||
Juwei, this bug indicates that the delete button is too easy to hit when you're typing on the keyboard. It has always been this way more or less; do you have any thoughts on having the delete button just show at the bottom (and not always float above the keyboard)?
Flags: needinfo?(jhuang)
Comment 7•10 years ago
|
||
The delete button should be always shown on the bottom instead of floating on screen.
Flags: needinfo?(jhuang)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → m
Target Milestone: --- → 1.4 S1 (14feb)
Assignee | ||
Comment 8•10 years ago
|
||
Per Juwei's UX feedback, this patch moves the Delete button from a positioned-absolute menu to always resting at the bottom of the form.
Attachment #8373613 -
Flags: review?(mmedeiros)
Comment 9•10 years ago
|
||
Comment on attachment 8373613 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16146 landed into master: https://github.com/mozilla-b2g/gaia/commit/60b7367e34ae791140cdfeeca0de113ca94a887d
Attachment #8373613 -
Flags: review?(mmedeiros) → review+
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
Whiteboard: dogfood1.3 → dogfood1.3 [p=1]
Comment 10•10 years ago
|
||
[Verified info] Gaia 6e71ab4da1b08586ea0c758edb7aa199ee34cd2f Gecko https://hg.mozilla.org/mozilla-central/rev/bb030d47c946 BuildID 20140219160202 Version 30.0a1 [Testing result] PASS Delete button has been deleted from a positioned-absolute and no other side effects. I mark it to "VERIFIED"
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•