963366 - Hide navigator.requestWakeLock and MozWakeLock from the web except on Firefox OS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

navigator.requestWakeLock and MozWakeLock only do something useful in Firefox OS, but they are currently exposed to all platforms unconditionally.  The WebIDL has a [Func="Navigator::HasWakeLockSupport"] attribute which may trick people into believing that these names are not exposed in some places but that function only makes sure that it can instantiate the nsIPowerManagerService service, which is available everywhere.

Kan-ru, is there any reason why we should not do this?  If not, are you interested in taking this bug?

Thanks!

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

We'll want this soonish, to prevent web pages from having the ability to prevent the screen saver from turning on in non-B2G builds.

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Fix leaked lastPermission var

mochitest-browser test can't use SpecialPowers.pushPermissions without this fix.

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/dom/power/test/browser_wakelocks.js | leaked window property: lastPermission

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Hide navigator.requestWakeLock behind pref dom.wakelock.enabled

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Re-enable basic power & wakelock tests for desktop

Was disabled entirely in bug 843893. I think we should at least run a subset of these tests.

Comment 5

[Masatoshi Kimura [:emk]]

An update to test_interfaces.html (and a review from a DOM peer) would be needed.

Comment 6

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Update test_interfaces.html

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

https://tbpl.mozilla.org/?tree=Try&rev=00a79b2ed68b

Comment 8

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

Comment on attachment 8373145 [details] [diff] [review]
Fix leaked lastPermission var

Review of attachment 8373145 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 9

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

Comment on attachment 8373147 [details] [diff] [review]
Re-enable basic power & wakelock tests for desktop

Review of attachment 8373147 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for cleaning up the moz.build rules and making the mochitest.ini more complete!

Comment 10

[(no longer active)]

Comment on attachment 8373146 [details] [diff] [review]
Hide navigator.requestWakeLock behind pref dom.wakelock.enabled

Review of attachment 8373146 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!  r=me with the below addressed.

::: dom/base/Navigator.cpp
@@ +1685,5 @@
>  Navigator::HasWakeLockSupport(JSContext* /* unused*/, JSObject* /*unused */)
>  {
> +  // First of all, the general pref has to be turned on.
> +  bool enabled = false;
> +  Preferences::GetBool("dom.wakelock.enabled", &enabled);

Please use a [Pref] attribute in the webidl instead.

Comment 11

[(no longer active)]

Also, can you please add a test which makes sure that navigator.requestWakeLock is unavailable in non-gonk platforms?

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Hide navigator.requestWakeLock behind pref dom.wakelock.enabled

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8373200 [details] [diff] [review]
Update test_interfaces.html

r=me

Comment 14

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/b2g-inbound/rev/86321b26161d
https://hg.mozilla.org/integration/b2g-inbound/rev/0af4a28621f7
https://hg.mozilla.org/integration/b2g-inbound/rev/b183597c0190
https://hg.mozilla.org/integration/b2g-inbound/rev/e0632c6aca0b

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Backed out for desktop B2G mochitest failures.
https://hg.mozilla.org/integration/b2g-inbound/rev/59af72902abf

https://tbpl.mozilla.org/php/getParsedLog.php?id=34479898&tree=B2g-Inbound

Comment 16

[Kan-Ru Chen [:kanru] (UTC+9)]

re-land:

https://hg.mozilla.org/integration/b2g-inbound/rev/3e66c5777cfe
https://hg.mozilla.org/integration/b2g-inbound/rev/c8655cd53cc1
https://hg.mozilla.org/integration/b2g-inbound/rev/d8c04dbd4886
https://hg.mozilla.org/integration/b2g-inbound/rev/5b263d1c94d7

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3e66c5777cfe
https://hg.mozilla.org/mozilla-central/rev/c8655cd53cc1
https://hg.mozilla.org/mozilla-central/rev/d8c04dbd4886
https://hg.mozilla.org/mozilla-central/rev/5b263d1c94d7

Comment 18

[Kohei Yoshino]

https://developer.mozilla.org/en-US/Firefox/Releases/30/Site_Compatibility