963440 - [zh-cn] Bookmark icon on Reading list page show as '%'

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

Attachment: Screenshot_2014-01-24-13-23-08.png

1. Install Fennec on a device with locale zh-cn
2. Launch Fennec and swipe to Reading list page
3. You will notice the TIP on the bottom of the page does not show bookmark icon. 
Please see attached screenshot for details.

Comment 1

[Lucas Rocha (:lucasr)]

liuche, any clues about why this is happening?

Comment 2

[Chenxia Liu [:liuche]]

It's not due to localization, as I first suspected - making a locale build to investigate further. It's probably a problem with how we find and replace the %I string, but I'll report back.

Comment 3

[Chenxia Liu [:liuche]]

I've made a multi-locale build, with the most recent aurora strings, and the icon is visible to me on the reading list page.

Can you tell me what device it is, and what date the build is from? If you are building this locally and have the locale strings, if you could verify that the "home_reading_list_hint" string contains the substring "%I"?

This is the string that I'm using in my multilocale build:
http://mxr.mozilla.org/l10n-mozilla-aurora/source/zh-CN/mobile/android/base/android_strings.dtd#291

Comment 4

[Peipei Cheng (needinfo if you need my action)]

The build I'm using is V27.0 beta 8/9 which is downloaded from ftp.mozilla.org. It's not self compiled.
And the device for test are:
Samsung Galaxy GT-P7510, Android 4.0.4.
MIUI 2S, android 4.1.1

I didn't check aurora builds. But from what u saw, it should have resolved this problem. maybe v27 build still does not include this string yet.

Comment 5

[Chenxia Liu [:liuche]]

Ah, that makes sense then. Looking at the 26 and 27 l10n, it looks like there's an error in the localization (but it's been corrected in 28):
http://mxr.mozilla.org/l10n-mozilla-beta/source/zh-CN/mobile/android/base/android_strings.dtd#289