963444 - Link to beta release notes is incorrect

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

1/22 version of beta on N4 404s when clicking on the Release Notes in about:firefox.

Comment 1

[Aaron Train [:aaronmt]]

http://www.mozilla.org/en-US/mobile/27.0beta/releasenotes/

http://mxr.mozilla.org/mozilla-beta/source/mobile/android/app/mobile.js#466

Our %VERSION% is 27.0 but the proper link appends 'beta'.

Comment 2

[Chenxia Liu [:liuche]]

Attachment: Patch: Create beta release notes link correctly

Comment 3

[Chenxia Liu [:liuche]]

This affects the current beta, and when 28 becomes aurora, will also affect that.

Tested that the link contains the "beta" string when built with MOZ_UPDATE_CHANNEL=beta.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8367473 [details] [diff] [review]
Patch: Create beta release notes link correctly

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Change in link url of beta release notes
User impact if declined: Beta release notes will continue to 404 until 29 becomes beta
Testing completed (on m-c, etc.): local build, verified that link changes for beta build, link does not change for release build
Risk to taking this patch (and alternatives if risky): low, link is already broken on beta
String or IDL/UUID changes made by this patch: none

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/059883f2def1

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/059883f2def1

Comment 7

[Chenxia Liu [:liuche]]

Aurora: https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=0450bbf43c38

Comment 8

[Flaviu Cos]

Verified as fixed on builds:
- 28 beta 1;
- 29.0a2 (2014-02-10);
Device: Google Nexus 7 (Android 4.4.2).

Comment 9

[Flaviu Cos]

The bug is still reproducible on nightly 30.0a1 (2014-02-10).
404 is received when clicking on the Release Notes in about:firefox.

Comment 10

[Aaron Train [:aaronmt]]

There are no nor ever will be any 'release-notes' for daily Nightly builds.