963488 - Remove nfc-manager permission from the browser

Status: RESOLVED DUPLICATE of bug 969217

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Stephanie Ouillon [:arroway] (needinfo me)]

The browser app should have the nfc-manager permission, since it allows an app to receive broadcasted messages from Chrome such as "nfc-manager-send-file", "nfc-manager-tech-discovered". Only the System app should have the nfc-manager permission to handle these messages.

Comment 1

[Garner Lee]

^^--- "The browser app should NOT have"

Comment 2

[Stephanie Ouillon [:arroway] (needinfo me)]

Epic fail with copy/paste :/, thx for the correction

Comment 3

[saminath]

 1.HandleVisibiltyChange() provides the Browser visibility information.
 Whenever enter into browser, document.hidden becomes false. Here I am adding the
 PeerHandler() to onpeerready.

 2.If we exit from the Browser, document.hidden becomes true, onpeerready becomes null.

 3.But the same time, while transfer URI data, Shrinking is enabled over the
 BrowserApplication,  document.hidden becomes true. I could not differentiate
 two different Normal exit and Shrink UI exit.
 
 Here I am doing additional checking along with "nfc-manager-tech-state"

Comment 4

[Garner Lee]

saminath: Applications (even certified applications like the browser) should not have any need for nfc-manager permissions. NFC Manager is a System App function, that routes system level NFC messages and events to all other NFC enabled applications installed in the FirefoxOS platform.

The browser needs read or write permisison only in the applicaiton manifest to support nfc:

readonly or readwrite.

 "permissions": {
   "nfc": { "access": "readwrite" }
 }

https://wiki.mozilla.org/WebAPI/WebNFC#NDEF_P2P_Push_Example

Comment 5

[Gregor Wagner [:gwagner]]

Garner, can you guys take this bug?

Comment 6

[Garner Lee]

I can take a look if he is busy. Sami?

I'm looking at the new browser dependence on shared/js/util.js, which is a bug that isn't checked in yet.

Comment 7

[Garner Lee]

Actually, Bug 969217 seems to have removed it already:
https://github.com/mozilla-b2g/gaia/commit/a075c52367e7a9c10a9c72704a29e6e178d70bb4