963502 - [MediaEncoder] OMXAudioEncoder will be out of input buffers if input segment is too big.

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[John Lin [:jhlin][:jolin]]

OMX encoder has limited input and output buffers. If client keep pushing input without pulling output, input buffers will all be full and dequeuing input buffer will fail.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Encode()/GetNextEncodedFrame() repeatly in OmxAudioTrackEncoder::GetEncodedTrack()

- Address input buffer exhausting issue when there are too many samples in source segment. If out of input buffer, consume some output buffer to make OMX encoder proceed encoding/release input buffers so we can feed more input data.
- Remove an assertion for output buffer size. (Turns out AAC encoder output buffer is not always 768 bytes long).

Comment 2

[John Lin [:jhlin][:jolin]]

try result: https://tbpl.mozilla.org/?tree=Try&rev=5b5c9366febb

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Encode()/GetNextEncodedFrame() repeatly in OmxAudioTrackEncoder::GetEncodedTrack()

Update commit message and carry r+ from roc.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d81ec82bda34

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d81ec82bda34