Closed Bug 963582 Opened 6 years ago Closed 6 years ago

Persona frame is not visible after tapping the login button

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed)

VERIFIED FIXED
1.3 C3/1.4 S3(31jan)
blocking-b2g 1.4+
Tracking Status
b2g-v1.4 --- fixed

People

(Reporter: Bebe, Assigned: etienne)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
STR:
1. Open any app that triggers a persona login (Marketplace)
2. Tap the login button
3. Wait for the persona frame to be visible

Expected:
3. The user should see the persona Frame

Actual:
3. the persona frame is not visible
   If we hold the home button to open cards view and go back to the app the persona frame will be triggered

Reproducing on:
Gaia      290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko     http://hg.mozilla.org/mozilla-central/rev/9d650c07b547
BuildID   20140124040404
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013
Summary: Persona frame is visible after taping the login button → Persona frame is not visible after taping the login button
Edwin - Can you investigate what's failing here?
Flags: needinfo?(edwong)
Component: Gaia::System → FxA
The same happened to me this morning: the trusted UI no longer appeared when request() was called.
(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #2)
> The same happened to me this morning: the trusted UI no longer appeared when
> request() was called.

Okay - so we aren't seeing this bug on production builds w/marketplace, but you saw it with the request() API call on nav.id. 

Note for Edwin - When you get the chance, can you get clear STR with a test app to demonstrate this bug?
blocking-b2g: --- → 1.4?
We were doing some payment testing today and noticed that it affects the payment popup too.

It might be a more general issue around handling popups.
If it's happening with payment tests as well, then it sounds like the Trusted UI and/or its interaction with the window manager may have been broken in gaia.  Jason, I would propose that this bug be reclassified as a gaia bug.  What do you think?
Flags: needinfo?(jsmith)
If someone can provide an end user STR to reproduce this, then that would help in diagnosing this.
blocking-b2g: 1.4? → ---
Component: FxA → Gaia::System::Window Mgmt
Flags: needinfo?(jsmith)
Keywords: regression
STR:
1. Start up FxOS device
2. Load 'Marketplace' app
3. Tap settings cog (top right corner)
4. Tap 'sign in/sign up'
- Note the behaviour, Marketplace app will stay open, spinner over the sign in button  -
5. Tap device 'Home' button and wait briefly; the Trusted UI will then slide open.
Okay - that sounds like an app transition bug - we should be transitioning to the homescreen when the trusted UI is activated.
blocking-b2g: --- → 1.4?
Flags: needinfo?(edwong)
QA Contact: jzimbrick
Regression Window:

Last Working Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140123040608
Gaia: 00d8d05f0d0730a3cbf17635ad6a6b197a2ce7c9
Gecko: 1a75d37e1e39
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140124040404
Gaia: 290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko: 9d650c07b547
Version: 29.0a1
Base Image: V1.2-device.cfg
Summary: Persona frame is not visible after taping the login button → Persona frame is not visible after tapping the login button
Have noticed that if the screen goes Off and the user turns it back to ON (power button) then Persona Sign In screen will be shown and user will be able to sign in. Having said that, if screen timeout is set to 10 min or never the user will have to wait forever.
Keywords: smoketest
Just tried to revert my commit, and the pb still exists,

but after revert this https://github.com/mozilla-b2g/gaia/commit/c8e20f65906eeb7071c7d3a97a781cbb0241ad65
pb fixed.
Flags: needinfo?(gduan)
ni correct person.

I think the pb is here.
#windows > .appWindow,
  #windows > .activityWindow {
Flags: needinfo?(etienne)
Attached file Gaia PR
(In reply to George Duan [:gduan] [:喬智] from comment #14)
> ni correct person.
> 
> I think the pb is here.
> #windows > .appWindow,
>   #windows > .activityWindow {

Shame on me :/

Here's a patch removing just this css change (I have another plan to fix the reflow as part of bug 962649).

Vivien, Alive, no need for 2 reviews just want to land this quickly :)
Assignee: nobody → etienne
Attachment #8366562 - Flags: review?(alive)
Attachment #8366562 - Flags: review?(21)
Flags: needinfo?(etienne)
Comment on attachment 8366562 [details] [review]
Gaia PR

Seems emergent so quick r+
Attachment #8366562 - Flags: review?(alive)
Attachment #8366562 - Flags: review?(21)
Attachment #8366562 - Flags: review+
Thanks Alive!
I'll just wait for Travis :)

(I remember a time when Travis prevented me from breaking the TrustedUI ;))
(In reply to Etienne Segonzac (:etienne) from comment #17)
> Thanks Alive!
> I'll just wait for Travis :)
> 
> (I remember a time when Travis prevented me from breaking the TrustedUI ;))

It will now!
(In reply to Zac C (:zac) from comment #18)
> (In reply to Etienne Segonzac (:etienne) from comment #17)
> > Thanks Alive!
> > I'll just wait for Travis :)
> > 
> > (I remember a time when Travis prevented me from breaking the TrustedUI ;))

Ya, SFO
http://i.imgur.com/mbGzSlV.jpg

> 
> It will now!

We have better to add one more travis hook to prevent etienne from checking code when his patch touches trustedUI!
We already had the python tests to protect against this but they were disabled for intermittent but we just re-enabled them yesterday!
These same tests caught it on device where the test was still enabled.
(In reply to Zac C (:zac) from comment #20)
> We already had the python tests to protect against this but they were
> disabled for intermittent but we just re-enabled them yesterday!

\o/
https://github.com/mozilla-b2g/gaia/commit/b9845c3bf8a7d5149943e31a3225aaeee57720e0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: 1.4? → 1.4+
Verified fixed in latest Buri Master M-C (1.4) build. 

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140129040244
Gaia: 59e477229162926981cc00cf5d6c53f9614f17dd
Gecko: 7e79536aca0a
Version: 29.0a1
v1.2-device.cfg
Status: RESOLVED → VERIFIED
Beautiful.  Thank you, everyone.
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
You need to log in before you can comment on or make changes to this bug.