963582 - Persona frame is not visible after tapping the login button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Florin Strugariu [:Bebe]]

STR:
1. Open any app that triggers a persona login (Marketplace)
2. Tap the login button
3. Wait for the persona frame to be visible

Expected:
3. The user should see the persona Frame

Actual:
3. the persona frame is not visible
   If we hold the home button to open cards view and go back to the app the persona frame will be triggered

Reproducing on:
Gaia      290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko     http://hg.mozilla.org/mozilla-central/rev/9d650c07b547
BuildID   20140124040404
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Comment 1

[Jason Smith [:jsmith]]

Edwin - Can you investigate what's failing here?

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

The same happened to me this morning: the trusted UI no longer appeared when request() was called.

Comment 3

[Jason Smith [:jsmith]]

(In reply to Jed Parsons (use needinfo, please) [:jedp, :jparsons] from comment #2)
> The same happened to me this morning: the trusted UI no longer appeared when
> request() was called.

Okay - so we aren't seeing this bug on production builds w/marketplace, but you saw it with the request() API call on nav.id. 

Note for Edwin - When you get the chance, can you get clear STR with a test app to demonstrate this bug?

Comment 4

[Zac C (:zac)]

We were doing some payment testing today and noticed that it affects the payment popup too.

It might be a more general issue around handling popups.

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

If it's happening with payment tests as well, then it sounds like the Trusted UI and/or its interaction with the window manager may have been broken in gaia.  Jason, I would propose that this bug be reclassified as a gaia bug.  What do you think?

Comment 6

[Jason Smith [:jsmith]]

If someone can provide an end user STR to reproduce this, then that would help in diagnosing this.

Comment 7

[Zac C (:zac)]

STR:
1. Start up FxOS device
2. Load 'Marketplace' app
3. Tap settings cog (top right corner)
4. Tap 'sign in/sign up'
- Note the behaviour, Marketplace app will stay open, spinner over the sign in button  -
5. Tap device 'Home' button and wait briefly; the Trusted UI will then slide open.

Comment 8

[Jason Smith [:jsmith]]

Okay - that sounds like an app transition bug - we should be transitioning to the homescreen when the trusted UI is activated.

Comment 9

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140123040608
Gaia: 00d8d05f0d0730a3cbf17635ad6a6b197a2ce7c9
Gecko: 1a75d37e1e39
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140124040404
Gaia: 290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko: 9d650c07b547
Version: 29.0a1
Base Image: V1.2-device.cfg

Comment 10

[Natalya Kot [:nkot]]

Have noticed that if the screen goes Off and the user turns it back to ON (power button) then Persona Sign In screen will be shown and user will be able to sign in. Having said that, if screen timeout is set to 10 min or never the user will have to wait forever.

Comment 11

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/compare/00d8d05f0d0730a3cbf17635ad6a6b197a2ce7c9...290efee3de3a12c9d803f4650d50bc7c7a8e1f2d

Comment 12

[Jason Smith [:jsmith]]

There's three system commits here to analyze:

1. https://github.com/mozilla-b2g/gaia/commit/c8e20f65906eeb7071c7d3a97a781cbb0241ad65
2. https://github.com/mozilla-b2g/gaia/commit/9bf818dde275aca39d00dd22f8814ae46fe89b7c
3. https://github.com/mozilla-b2g/gaia/commit/f50e115ee96264371843a742fa7ecc1a4075283e

George - Can you double check if your patch caused this regression (commit number 3)?

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Just tried to revert my commit, and the pb still exists,

but after revert this https://github.com/mozilla-b2g/gaia/commit/c8e20f65906eeb7071c7d3a97a781cbb0241ad65
pb fixed.

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

ni correct person.

I think the pb is here.
#windows > .appWindow,
  #windows > .activityWindow {

Comment 15

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

(In reply to George Duan [:gduan] [:喬智] from comment #14)
> ni correct person.
> 
> I think the pb is here.
> #windows > .appWindow,
>   #windows > .activityWindow {

Shame on me :/

Here's a patch removing just this css change (I have another plan to fix the reflow as part of bug 962649).

Vivien, Alive, no need for 2 reviews just want to land this quickly :)

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8366562 [details] [review]
Gaia PR

Seems emergent so quick r+

Comment 17

[Etienne Segonzac (:etienne)]

Thanks Alive!
I'll just wait for Travis :)

(I remember a time when Travis prevented me from breaking the TrustedUI ;))

Comment 18

[Zac C (:zac)]

(In reply to Etienne Segonzac (:etienne) from comment #17)
> Thanks Alive!
> I'll just wait for Travis :)
> 
> (I remember a time when Travis prevented me from breaking the TrustedUI ;))

It will now!

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Zac C (:zac) from comment #18)
> (In reply to Etienne Segonzac (:etienne) from comment #17)
> > Thanks Alive!
> > I'll just wait for Travis :)
> > 
> > (I remember a time when Travis prevented me from breaking the TrustedUI ;))

Ya, SFO
http://i.imgur.com/mbGzSlV.jpg

> 
> It will now!

We have better to add one more travis hook to prevent etienne from checking code when his patch touches trustedUI!

Comment 20

[Zac C (:zac)]

We already had the python tests to protect against this but they were disabled for intermittent but we just re-enabled them yesterday!
These same tests caught it on device where the test was still enabled.

Comment 21

[Etienne Segonzac (:etienne)]

(In reply to Zac C (:zac) from comment #20)
> We already had the python tests to protect against this but they were
> disabled for intermittent but we just re-enabled them yesterday!

\o/

Comment 22

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/b9845c3bf8a7d5149943e31a3225aaeee57720e0

Comment 23

[Tony Nguyen]

Verified fixed in latest Buri Master M-C (1.4) build. 

Environmental Variables:
Device: Buri Master M-C mozRIL
BuildID: 20140129040244
Gaia: 59e477229162926981cc00cf5d6c53f9614f17dd
Gecko: 7e79536aca0a
Version: 29.0a1
v1.2-device.cfg

Comment 24

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Beautiful.  Thank you, everyone.