until method does not take a custom message

RESOLVED FIXED in Firefox OS v1.3

Status

Testing
Marionette
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zac, Assigned: ato)

Tracking

unspecified
mozilla29
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(b2g-v1.3 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
The Wait class's until method does not take a custom failure message. Selenium2's does.

When using obtuse conditions in the Wait class the default failure message can be quite vague so overriding it is beneficial for debugging.
(Assignee)

Comment 1

4 years ago
That makes sense.  It's great to hear the use cases.
Assignee: nobody → ato
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8365959 [details] [diff] [review]
0001-Bug-963598-Allow-custom-message-when-Wait.until-time.patch

try: https://tbpl.mozilla.org/?tree=Try&rev=f1ad261a2d34
Attachment #8365959 - Flags: review?(zcampbell)
Comment on attachment 8365959 [details] [diff] [review]
0001-Bug-963598-Allow-custom-message-when-Wait.until-time.patch

Review of attachment 8365959 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review as it's blocking the release. Looks great, thanks Andreas!
Attachment #8365959 - Flags: review?(zcampbell) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/499a39c0e2ad
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
status-b2g-v1.3: --- → fixed
You need to log in before you can comment on or make changes to this bug.