963639 - CustomizeMode _onToolbarVisibilityChange sets @customizing on non-customizable toolbars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Matthew N. [:MattN]]

This is just wrong and should be fixed. It may cause areas to be highlighted/treated as customizable when they are not.

Comment 1

[:Gijs (he/him)]

Attachment: only make Australis customization mode set customizing=true on toolbars which are customizable,

Seems to me this is all that needs to happen, right? I hope you don't mind that I'm stealing this, it's so low effort that I figured we should just take the fix already.

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8371463 [details] [diff] [review]
only make Australis customization mode set customizing=true on toolbars which are customizable,

Review of attachment 8371463 [details] [diff] [review]:
-----------------------------------------------------------------

That's fine that you took it. I wasn't going to get to it this week. That's all I had in mind for the fix too so r=me. Of course a simple test would be nice but I'm not sure it's worth the effort at this point. I'll mark in-testsuite? so someone can come back and write a test.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8371463 [details] [diff] [review]
only make Australis customization mode set customizing=true on toolbars which are customizable,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: add-on toolbars could start behaving weirdly in customize mode if removed/re-added
Testing completed (on m-c, etc.): local
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none

remote:   https://hg.mozilla.org/integration/fx-team/rev/34922bfad654

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/34922bfad654

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a3b25dcd0fd9

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

The automated test for this was tracked in bug 977033 and was landed in https://hg.mozilla.org/mozilla-central/rev/d36aeeed76a9