C++ unit tests not getting stripped

RESOLVED FIXED in mozilla29

Status

Firefox Build System
General
RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

(Blocks: 1 bug)

Trunk
mozilla29
All
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
bug 920055 regressed this. It's using $(OBJCOPY) $(STRIP_FLAGS), but STRIP_FLAGS is unset by default, and running objcopy without any flags doesn't actually do any stripping.
(Assignee)

Comment 1

4 years ago
Created attachment 8365174 [details] [diff] [review]
strip C++ unit tests even when STRIP_FLAGS are unset

Simple fix, just default to --strip-unneeded.
Attachment #8365174 - Flags: review?(mh+mozilla)
Comment on attachment 8365174 [details] [diff] [review]
strip C++ unit tests even when STRIP_FLAGS are unset

Stealing from glandium - looks good to me!
Attachment #8365174 - Flags: review?(mh+mozilla) → review+

Comment 3

4 years ago
Landed to help with ftp load:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/431612fab17e

Thank you for this :-)
https://hg.mozilla.org/mozilla-central/rev/431612fab17e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.