Closed Bug 963651 Opened 9 years ago Closed 9 years ago

C++ unit tests not getting stripped

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

strip C++ unit tests even when STRIP_FLAGS are unset
1.39 KB, patch
mshal
: review+
Details | Diff | Splinter Review 
bug 920055 regressed this. It's using $(OBJCOPY) $(STRIP_FLAGS), but STRIP_FLAGS is unset by default, and running objcopy without any flags doesn't actually do any stripping.
Simple fix, just default to --strip-unneeded.
Attachment #8365174 - Flags: review?(mh+mozilla)
Comment on attachment 8365174 [details] [diff] [review]
strip C++ unit tests even when STRIP_FLAGS are unset

Stealing from glandium - looks good to me!
Attachment #8365174 - Flags: review?(mh+mozilla) → review+
Landed to help with ftp load:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/431612fab17e

Thank you for this :-)
https://hg.mozilla.org/mozilla-central/rev/431612fab17e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.