Closed
Bug 963665
Opened 11 years ago
Closed 11 years ago
Make nsIXPConnect noscript
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
|
897 bytes,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
I can't see any reason for making this available to script, but maybe I'm wrong.
|
Assignee | |
Comment 1•11 years ago
|
||
A full try run was green: https://tbpl.mozilla.org/?tree=Try&rev=c6c74c797a99
Attachment #8365671 -
Flags: review?(bobbyholley+bmo)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8365671 [details] [diff] [review]
Make nsIXPConnect noscript.
Review of attachment 8365671 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/idl/nsIXPConnect.idl
@@ +273,5 @@
> { 0xcb6593e0, 0xf9b2, 0x11d2, \
> { 0xbd, 0xd6, 0x0, 0x0, 0x64, 0x65, 0x73, 0x74 } }
> %}
>
> +[noscript, uuid(74109b69-de2f-4296-9e08-2a233eafa8f9)]
I guess there's no reason to rev the UUID here, since this doesn't affect C++? TBH I'd prefer to just rev it anyway to be safe.
Attachment #8365671 -
Flags: review?(bobbyholley+bmo) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Yeah, per the XPIDL page, noscript doesn't affect binary compatibility. But I can rev it to make you feel better. ;)
|
|
Assignee | |
Comment 4•11 years ago
|
||
updated the UUID
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e6349f0a18d
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•