Make nsIXPConnect noscript

RESOLVED FIXED in mozilla29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

({addon-compat})

Trunk
mozilla29
addon-compat
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I can't see any reason for making this available to script, but maybe I'm wrong.
(Assignee)

Comment 1

5 years ago
Created attachment 8365671 [details] [diff] [review]
Make nsIXPConnect noscript.

A full try run was green: https://tbpl.mozilla.org/?tree=Try&rev=c6c74c797a99
Attachment #8365671 - Flags: review?(bobbyholley+bmo)
Comment on attachment 8365671 [details] [diff] [review]
Make nsIXPConnect noscript.

Review of attachment 8365671 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/idl/nsIXPConnect.idl
@@ +273,5 @@
>  { 0xcb6593e0, 0xf9b2, 0x11d2, \
>      { 0xbd, 0xd6, 0x0, 0x0, 0x64, 0x65, 0x73, 0x74 } }
>  %}
>  
> +[noscript, uuid(74109b69-de2f-4296-9e08-2a233eafa8f9)]

I guess there's no reason to rev the UUID here, since this doesn't affect C++? TBH I'd prefer to just rev it anyway to be safe.
Attachment #8365671 - Flags: review?(bobbyholley+bmo) → review+
(Assignee)

Comment 3

5 years ago
Yeah, per the XPIDL page, noscript doesn't affect binary compatibility.  But I can rev it to make you feel better. ;)
https://hg.mozilla.org/mozilla-central/rev/8e6349f0a18d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.