963665 - Make nsIXPConnect noscript

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

I can't see any reason for making this available to script, but maybe I'm wrong.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Make nsIXPConnect noscript.

A full try run was green: https://tbpl.mozilla.org/?tree=Try&rev=c6c74c797a99

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8365671 [details] [diff] [review]
Make nsIXPConnect noscript.

Review of attachment 8365671 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/idl/nsIXPConnect.idl
@@ +273,5 @@
>  { 0xcb6593e0, 0xf9b2, 0x11d2, \
>      { 0xbd, 0xd6, 0x0, 0x0, 0x64, 0x65, 0x73, 0x74 } }
>  %}
>  
> +[noscript, uuid(74109b69-de2f-4296-9e08-2a233eafa8f9)]

I guess there's no reason to rev the UUID here, since this doesn't affect C++? TBH I'd prefer to just rev it anyway to be safe.

Comment 3

[Andrew McCreight [:mccr8]]

Yeah, per the XPIDL page, noscript doesn't affect binary compatibility.  But I can rev it to make you feel better. ;)

Comment 4

[Andrew McCreight [:mccr8]]

updated the UUID

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e6349f0a18d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e6349f0a18d