963779 - JavaScript error: chrome://browser/content/customizableui/panelUI.js, line 343: this.hide is not a function

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Avi Halachmi (:avih)]

Whenever I click menu -> '?' -> About Nightly, I get the following error at the console (the command line console, not the browser console):

JavaScript error: chrome://browser/content/customizableui/panelUI.js, line 343: this.hide is not a function

I saw it on windows 7, mconley reproduced it on OS X.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This doesn't appear to break functionality, but we still shouldn't have this - marking as P4 for now.

Comment 2

[:Gijs (he/him)]

Attachment: fix Australis issue with |this| not being |PanelUI|,

D'oh. My mistake.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8365670 [details] [diff] [review]
fix Australis issue with |this| not being |PanelUI|,

PanelUI should be the event listener here rather than PanelUI.onCommandHandler, to prevent this kind of issue. This code could move in handleEvent or handleEvent could call onCommandHandler.

Comment 4

[:Gijs (he/him)]

Attachment: use handleEvent for Australis command handler,

Comment 5

[:Gijs (he/him)]

Attachment: use handleEvent for Australis command handler,

Wrong patch.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8365980 [details] [diff] [review]
use handleEvent for Australis command handler,

Review of attachment 8365980 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - let's roll.

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/288c524e1004

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/288c524e1004