JavaScript error: chrome://browser/content/customizableui/panelUI.js, line 343: this.hide is not a function

RESOLVED FIXED in Firefox 29

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: avih, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P4])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Whenever I click menu -> '?' -> About Nightly, I get the following error at the console (the command line console, not the browser console):

JavaScript error: chrome://browser/content/customizableui/panelUI.js, line 343: this.hide is not a function

I saw it on windows 7, mconley reproduced it on OS X.
This doesn't appear to break functionality, but we still shouldn't have this - marking as P4 for now.
Whiteboard: [Australis:P4]
OS: Windows 7 → All
(Assignee)

Updated

5 years ago
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 8365670 [details] [diff] [review]
fix Australis issue with |this| not being |PanelUI|,

D'oh. My mistake.
Attachment #8365670 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8365670 [details] [diff] [review]
fix Australis issue with |this| not being |PanelUI|,

PanelUI should be the event listener here rather than PanelUI.onCommandHandler, to prevent this kind of issue. This code could move in handleEvent or handleEvent could call onCommandHandler.
Attachment #8365670 - Flags: review?(mconley) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 8365979 [details] [diff] [review]
use handleEvent for Australis command handler,
Attachment #8365979 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Attachment #8365670 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
Created attachment 8365980 [details] [diff] [review]
use handleEvent for Australis command handler,

Wrong patch.
Attachment #8365980 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Attachment #8365979 - Attachment is obsolete: true
Attachment #8365979 - Flags: review?(mconley)
Comment on attachment 8365980 [details] [diff] [review]
use handleEvent for Australis command handler,

Review of attachment 8365980 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - let's roll.
Attachment #8365980 - Flags: review?(mconley) → review+
(Assignee)

Comment 7

5 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/288c524e1004
Whiteboard: [Australis:P4] → [Australis:P4][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/288c524e1004
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P4][fixed-in-fx-team] → [Australis:P4]
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.