963836 - OpenH264: "runtime error: load of misaligned address for type 'uint32_t'" to kuiABCD

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase.264

In order to reproduce you need to compile OpenH264 with UBSan support.

export CC="$LLVM_HOME/build/bin/clang -fsanitize=undefined -fno-sanitize=vptr"
export CXX="$LLVM_HOME/build/bin/clang++ -fsanitize=undefined -fno-sanitize=vptr"
export LD="$LLVM_HOME/build/bin/clang++"
export LDFLAGS="-fsanitize=undefined"
make


codec/decoder/./core/src/mc.cpp:330:28: runtime error: load of misaligned address 0x000c64a6 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment

const uint32_t kuiABCD = * ((uint32_t*)g_kuiABCD[iMvY & 0x07][iMvX & 0x07]);


I will hide this bug first because I am not sure how you would like me to treat this class of bugs.


Tested with https://github.com/cisco/openh264/commit/58c33b8ee8

Comment 1

[wayne]

Hi Christoph, we'll deal with it after our holiday (Chinese Spring Festival is coming:) )
hope it will not block your work.

Comment 2

[Christoph Diehl [:posidron]]

No, that's totally fine. Enjoy!

Comment 3

[wayne]

Hi Christoph, the bug has been solved by early fix from others.
Could you please check it with latest cisco master branch?
btw: the codec has other similar issues not reflected by this bitstream, and we'll deal with this in future.

Comment 4

[Andrew McCreight [:mccr8]]

Could you confirm that this is fixed, Christoph?  Thanks.

Comment 5

[Christoph Diehl [:posidron]]

Fixed.

Tested with https://github.com/cisco/openh264/commit/75f8b41bcd