96384 - Implement generic inline-edit functionality

Status: NEW

(Core :: XUL, enhancement, P3)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The bookmarks upgrade screams for inline edit functionality. I decided the best
way to implement it is as follows:

- create a generic inline-edit binding which can attach itself to a widget (e.g.
a bookmarks toolbar or an outliner) and obtain positioning information from that
widget. 

- when inline edit mode is invoked (I will add support for this to the outliner
binding in outliner.xml, other uses will activate it via an API on the inline
edit binding), a popup is created at the position specified by the widget that
owns the inline-edit functionality. This is typically over the text region of
the selected item. 

- keyboard & blur handling will be implemented

- a notification interface will allow the owner to determine if the value
entered is valid, and if it is, what to do with it.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

set up dependencies. 

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Inline edit was cut. 

Comment 4

[Blake Ross]

*** Bug 47771 has been marked as a duplicate of this bug. ***

Comment 5

[Jan Varga [:janv]]

It would be nice to have this in Buffy, nominating
cc Patrice for UE input

Comment 6

[patrice caire]

Jan: How can I help you?

Comment 7

[Jan Varga [:janv]]

I need some info before implementing this feature, I'm also waitting for nsbeta1+ 
I'd like to implement inline editing in bookmarks, but I'm not sure how it
should behave. First, I need to know how to invoke inline editting, after two
clicks ?
Then display an editable textbox sized to the edited cell ?
Should the texbox automatically resize or wrap edited text ?
Should I get inspired by windows explorer ?

Comment 8

[patrice caire]

The 2 clicks sound good Jan, and then displaying an editable textbox sized to
the edited cell too. It seems that having a texbox automatically resize would be
better than wrap edited text. Looking at windows explorer to check how it works
there is a good idea too. Great suggestions.

Comment 9

[Jan Varga [:janv]]

thanks for the confirmation Patrice

Comment 10

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 11

[Pavel Hlavnicka]

Just want to tell, that this feature seems be essential for application
development. Mozilla geeks should support this feature if they really want to
expose XUL to application developers.

The workaround I've found is placing the tree into 'bulletinboard' and use
'textbox' shown on demand (treeBoxObject.getCoordsForCellItem helps) and update
internal object implemention nsITreeView. Hope it helps somebody.

Comment 12

[Jan Varga [:janv]]

Yeah, actually David Hyatt and I were talking about possible implementations
some time ago. Using a deck (bulletinboard) was one of them.
I'd like to take a look if you have a working implementation.

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #12)
> Yeah, actually David Hyatt and I were talking about possible implementations
> some time ago. Using a deck (bulletinboard) was one of them.
> I'd like to take a look if you have a working implementation.
> 

Something like a deck containing a label and a textbox, then switching to the textbox when you click the label?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.