963880 - [B2G][Browser] Broken design on "bookmark edit page" when changing between portrait and landscape views

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[sarsenyev]

Attachment: VideoBug

Description:
In edit mode the "bookmark" page has a broken design when switching between portrait and landscape view, 

Repro Steps:
1) Updated Buri to BuildID: 20140124004002
2) Open any bookmark from browser
3) Tap the "star" icon and navigate to "Edit bookmark"
4) Tap some fields to see the keyboard pops up
5) Switch the device to landscape view

Actual:
Some Settings design appears like "Settings" Privacy & Security" and fields are covered  

Expected:
Design is not broken 

Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140124004002
Gaia: e5137ed5589d7f3bf0260b8920f874cd0f462f69
Gecko: a73b697b50b3
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[sarsenyev]

The issue also reproduces on 1.2

Gaia   539a25e1887b902b8b25038c547048e691bd97f6
SourceStamp 4494940fb3ea
BuildID 20140123004001
Version 26.0

Comment 2

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 3

[gbennett]

This does not reproduce on 1.1 following the STR and comparing against the attached video.

Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140123041201
Gaia: c434fe9a0e823029796805e141cfa983cda2d246
Gecko: aa0ceb07a73e
Version: 18.0
Firmware Version: v1.2-device.cfg

Comment 4

[Jason Smith [:jsmith]]

If I leave the UI that's broken after it renders, does it never come back unless I execute the STR here? Or does it permanently hang around?

Comment 5

[Brogan Zumwalt [Inactive]]

Since the exit button is cut off by the UI issue, the only way to exit the page is to press the home button. If you reopen the browser without closing app in card view, this issue persists.

If you close the app through the card view then reopen the browser, the UI issue does not persist without repeating STR.

Comment 6

[J Zimbrick]

Regression Window:

Last Working Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130806104538
Gaia: 42c4efb7550820b7b6d6086d419a32a9e0cad174
Gecko: 1e381c91885d
Version: 26.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri v1.2 Mozilla RIL
BuildID: 20130807070231
Gaia: 322389dddc458c3105978b7db6f485d8894cc487
Gecko: 1fb5d14e8348
Version: 26.0a1
Base Image: V1.2-device.cfg

Comment 7

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/compare/42c4efb7550820b7b6d6086d419a32a9e0cad174...322389dddc458c3105978b7db6f485d8894cc487

Comment 8

[Jason Smith [:jsmith]]

There's two browser commits in this range:

1. https://github.com/mozilla-b2g/gaia/commit/7ef684700dcd8a297e39aae8407cd7d5896ff290
2. https://github.com/mozilla-b2g/gaia/commit/dd3d9988cac48c12198d98208372f3d419533972

Comment 9

[Hema Koka [:hema]]

Wilsonpage, could you take a shot at investigating whats going on here? Assigning to you for investigation

Thank you!

Hema

Comment 10

[Ben Francis [:benfrancis]]

Stealing, sorry Wilson :)

Comment 11

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15868

quickfix

Comment 12

[Ben Francis [:benfrancis]]

It was caused by https://github.com/mozilla-b2g/gaia/commit/dd3d9988cac48c12198d98208372f3d419533972 when display:none was removed from #settings, but this is needed to make the animation work. So this is a workaround that makes sure the bookmark entry sheet and settings panel are not displayed at the same time.

Comment 13

[Wilson Page [:wilsonpage]]

Attachment: 2014-01-31-10-01-15.png

Comment 14

[Wilson Page [:wilsonpage]]

I've had a poke around and it seems that this issue is deeper than an application CSS issue. Observing the screenshot I attached you can see than upon opening the keyboard in landscape mode, then entire application UI shifts upwards about 40px. I'm guessing this is an issue with the keyboard application, and more specifically the logic required to scroll off-screen focused input fields into view.

I have tried to see if I can recreate something similar in other apps, but it seems landscape orientation is disabled most applications that have form inputs (email, messaging, contacts, settings). But I'm going to guess that this issue is not unique to Browser.

Interestingly the issue disappears when running a v1.3 Gaia on top of latest Gecko. Although the application UI does not appear broken, the focused form field fails to scroll into view, making text input in the 'address' field impossible in landscape orientation.

I'm not sure what else I can do here, this bug now appears to be too far from my area of knowledge. I hope this investigation has helped somewhat!

Comment 15

[Ben Francis [:benfrancis]]

Attachment: 2014-01-31-10-29-25.png

(In reply to Wilson Page [:wilsonpage] from comment #13)
> Created attachment 8368561 [details]
> 2014-01-31-10-01-15.png

Damn, how did you do that? I can't reproduce that (see screenshot).

If it needs a broader fix then please feel free to steal back the bug as I may not have time to fix it today now.

Comment 16

[Wilson Page [:wilsonpage]]

The screenshot shows what's beneath the Edit Bookmark dialog when the application gets into that state, attempting to illustrate the scope of the issue. I used the devtools to hide the Edit Bookmarks, so it would be possible for a user to recreate this.

As I said, this issue is waaaaaay beyond my understanding of Gaia.

Comment 17

[Wilson Page [:wilsonpage]]

* wouldn't be possible for a user to recreate this

Comment 18

[Ben Francis [:benfrancis]]

Oh right, yes. There may be a wider issue here.

My hunch would be either a window manager bug or something to do with the browser's body tag being set to display:relative. I'm not convinced the bug is outside the browser app because if you set the settings panel to display:none the app doesn't get shifted upwards.

Unfortunately I've run out of time to work on this. I think my quick fix patch does fix the bug described here, so we could land that and file a follow up. But if there's a bug that reproduces elsewhere as well and someone can find a broader fix today then feel free to steal the bug.

Comment 19

[Dale Harvey (:daleharvey)]

Comment on attachment 8368544 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15868

Looking good, apologies for the delay

Comment 20

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/99206e666bd52e4f5af0d1b46e8a0db415330ba7

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 99206e666bd52e4f5af0d1b46e8a0db415330ba7 to:
v1.3: 4cc9855f4ab77e39aedaa656fc5c25a2031fe39b