963983 - madvise on SunOS not defined: detect and use posix_madvise

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Isaac Z. Schlueter]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.77 Safari/537.36

Steps to reproduce:

Try to build mozjs on SmartOS system


Actual results:

Build failed, because madvise was not found.

Replacing all instances of madvise to posix_madvise allowed build to proceed.


Expected results:

Build should have proceeded without errors.

Comment 1

[Petr Sumbera]

Attachment: Bug963983.patch

Ideally I would love to use just posix_madvise(). But there seems to be semantic problem when MADV_DONTNEED is used [1] between Linux and Solaris (or Linux and everyone else ?!).

[1] http://man7.org/linux/man-pages/man3/posix_madvise.3.html (see NOTES)

Please see also:

https://bugzilla.mozilla.org/show_bug.cgi?id=1158445

Comment 2

[Petr Sumbera]

Can anybody please change platform field? This is not MacOS (it was reported as SmarOS issue). But more generally it's SunOS/Solaris issue.

And also I'm not able to add checkin-needed keyword. Please do it for me too.

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

I went with "Other" since SunOS and Solaris aren't listed as options. To sheriffs: we don't test this platform in automation, so a try run wouldn't do much good here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbcf6ffad5d0
posix_madvise() should be used instead of madvise() on Solaris. r=jandem

Comment 5

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/cbcf6ffad5d0