963991 - [Rocketbar] Implement SearchWindow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It seems that we may want to move rocketbar into an app manager window. Opening this bug to track that work.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github commit WIP

Alive - this is one commit on the pull request here: https://github.com/mozilla-b2g/gaia/pull/15701

The commit moves rocketbar into an app window, and has a RocketbarLauncher. This is similar to Homescreen and HomescreenLauncher. Can you tell me if you think there is value in doing this? If we do not, I think we may end up with a bunch of hacks all over the place.

Let me know what you think. If you like the direction I will clean it up and fix/add necessary unit tests. Thanks!

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8365610 [details]
Github commit WIP

Left some comments in your github.

Kevin, thank you for having this. I think this is a better way to go.
Let's discuss more during ww.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Move into new Window Management.

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Just a 5c from the a11y point of view, this will help out in handling rocket bar elements/components with the screen reader.

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Hey Alive - when you have a chance please review this. This is a much more simplified version of the previous one. This attempt only moves the search area into an AppWindow, and Rocketbar.js will manage it. Please let me know what you think.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8401922 [details] [review]
Github pull request

r+ if failed tests are fixed.

Comment 7

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/80690e0f4b48abd9d4d239f300a04a33eaabd674