Closed
Bug 964000
Opened 10 years ago
Closed 10 years ago
[Holly] Perma orange TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown on a unsecure host when override pref is set
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 29
Tracking | Status | |
---|---|---|
firefox27 | --- | unaffected |
firefox28 | --- | unaffected |
firefox29 | --- | fixed |
firefox-esr24 | --- | unaffected |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [Australis:P1])
Attachments
(1 file)
1.29 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
Holly went orange after a mozilla-central merge, and it seems to be related to UITour stuff. The particulars: This bc orange appears on OS X and Windows only, it seems. Here's what we're getting from the logs[1]: TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown on a unsecure host when override pref is set TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() 10:51:24 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown on a unsecure host when override pref is set 10:51:24 INFO - Stack trace: 10:51:24 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: is_element_visible :: line 44 10:51:24 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test_unsecure_host_override/< :: line 108 10:51:24 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be hidden after UITour tab is closed 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Popup should be closed/hidding after UITour tab is closed 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Any pinned tab should be closed after UITour tab is closed 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should initially be hidden 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should not be shown when feature is disabled 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be hidden after UITour tab is closed 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Popup should be closed/hidding after UITour tab is closed 10:51:24 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Any pinned tab should be closed after UITour tab is closed 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should initially be hidden 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:25 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() 10:51:25 INFO - Stack trace: 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: is_element_visible :: line 44 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test_highlight :: line 131 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test/nextTest/< :: line 72 10:51:25 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be hidden after hideHighlight() 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:25 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() 10:51:25 INFO - Stack trace: 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: is_element_visible :: line 44 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test_highlight :: line 137 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test/nextTest/< :: line 72 10:51:25 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 10:51:25 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Element should not be null, when checking visibility 10:51:25 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js | Highlight should be shown after showHighlight() 10:51:25 INFO - Stack trace: 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/head.js :: is_element_visible :: line 44 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test_highlight :: line 139 10:51:25 INFO - JS frame :: chrome://mochitests/content/browser/browser/modules/test/browser_UITour.js :: test/nextTest/< :: line 72 10:51:25 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 I could very well be to blame for this one, since I performed the merge, and there was some small foul-up with the UITourHighlightContainer in browser.xul[2]. I might have merged it incorrectly. [1]: Example - https://tbpl.mozilla.org/php/getParsedLog.php?id=33538071&tree=Holly [2]: http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#217
Assignee | ||
Updated•10 years ago
|
Keywords: intermittent-failure
Assignee | ||
Comment 1•10 years ago
|
||
This is the fragment I had to manually resolve the conflict on when I did the merge, and I chose what was coming from mozilla-central. That choice is what's causing the orange - reverting to what was originally set here in browser.xul causes the tests to pass for me locally. Is this what we want on Holly? Or, do we actually want this change from mozilla-central, and need to port the other elements of the change as well?
Attachment #8365628 -
Flags: review?(bmcbride)
Comment 2•10 years ago
|
||
Comment on attachment 8365628 [details] [diff] [review] Patch v1 Review of attachment 8365628 [details] [diff] [review]: ----------------------------------------------------------------- Yea, this is right for Holly.
Attachment #8365628 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks, landed on Holly: https://hg.mozilla.org/projects/holly/rev/551a9c6cf0e8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•10 years ago
|
status-firefox27:
--- → unaffected
status-firefox28:
--- → unaffected
status-firefox29:
--- → fixed
status-firefox-esr24:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•