964075 - clang build warning: xpcom/components/nsComponentManager.cpp:99:12: warning: unused variable 'classIDKeyName' [-Wunused-const-variable], and many more

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: warnings list

Clang 3.4 and 3.5 (at least) have a warning for "-Wunused-const-variable". (Apparently earlier compilers don't warn about unused variables if they're const, or something, but clang now does.)

We hit a bunch of instances of this in nsComponentManager.cpp, starting with:
{
 0:28.44 Warning: -Wunused-const-variable in /mozilla-central/xpcom/components/nsComponentManager.cpp: unused variable 'classIDKeyName'
 0:28.44 /mozilla-central/xpcom/components/nsComponentManager.cpp:99:12: warning: unused variable 'classIDKeyName' [-Wunused-const-variable]
 0:28.44 const char classIDKeyName[]="classID";
 0:28.44            ^
}

I'm attaching a text file with the rest, since the lines are all a bit long and they would look ugly in a bugzilla comment.

Comment 1

[Daniel Holbert [:dholbert]]

Note: it looks like ehsan fixed some of these back in
 http://hg.mozilla.org/mozilla-central/rev/a73ffb0d0c97#l26.1
but hit build bustage and backed out in
 http://hg.mozilla.org/mozilla-central/rev/64e2f1061cde

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

Green try run: https://tbpl.mozilla.org/?tree=Try&rev=fe152d3d112c (aside from one unrelated 'make check' test-failure)

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8365701 [details] [diff] [review]
fix v1

Review of attachment 8365701 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing review.  Getting rid of unused things is uncontroversial.

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/849b1268eb86

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/849b1268eb86