localizing preferences doesn't work: /sdk/l10n/prefs.js has a typo and throws

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: zombie, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
noticed while working on native options (bug 903039), noted here to investigate later..

    function onOptionsDisplayed({ subjec: document, data: addonId }) {

https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/l10n/prefs.js#L12
(Reporter)

Comment 1

4 years ago
isn't it ironic..
Blocks: 903039
Summary: localizing preferences doesn't work, /sdk/l10n/prefs.js has as typo and throws → localizing preferences doesn't work: /sdk/l10n/prefs.js has a typo and throws
Assignee: nobody → evold
Attachment #8365790 - Attachment mime type: text/plain → text/html
Attachment #8365790 - Flags: review?(jsantell) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/15c58719a368e651da0e459f042bb6072fbe2387
Bug 964128 - localizing preferences doesn't work: /sdk/l10n/prefs.js has a typo and throws

https://github.com/mozilla/addon-sdk/commit/363f362af84e59841ae70e4e2f61dd96d418a705
Merge pull request #1366 from erikvold/964128

Bug 964128 - localizing preferences doesn't work: /sdk/l10n/prefs.js has a typo and throws r=@jsantell
Blocks: 966416
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.