964281 - Hang when opening log file on http://nightly.mpc-hc.org/

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

1. Go to http://nightly.mpc-hc.org/
2. Click on log file (it's on the bottom)
3. Enjoy the hang

Comment 1

[Alice0775 White]

Stack on hang:bp-b42708d4-a189-43c8-b087-2b52b2140127


Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/d58ab6f6ca0a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131117145336
Bad:
http://hg.mozilla.org/mozilla-central/rev/59f6274ce8f1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118025341
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d58ab6f6ca0a&tochange=59f6274ce8f1


Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/6f5bbe846139
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131116233338
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/bdf16bdfce5a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131117023737
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6f5bbe846139&tochange=bdf16bdfce5a

Regressed by: Bug 646359 or Bug 936935

Comment 2

[Benjamin Kerensa [:bkerensa]]

Can you have a look at this since you landed the patches in the regression window?

Comment 3

[Alice0775 White]

In local build
Last Good: ec7b5c159c31
First Bad: bdf16bdfce5a
Triggered by: bdf16bdfce5a	Simon Montagu — Optimize bidi resolution on blocks without mixed-direction text. Bug 646359, r=roc

Comment 6

[Simon Montagu :smontagu]

Attachment: Updated patch

Comment 7

[Simon Montagu :smontagu]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b732738b75f8

Comment 8

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/b732738b75f8

(for uplift, please get the bug number correct in the commit message; now the sheriff resolved bug 964821 instead)

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Can this get uplift?  We're taking our last landings to FF28 beta today if tracked & low risk so please nominate (or comment as to not nominating) if this is safe to take.

Comment 10

[Simon Montagu :smontagu]

Comment on attachment 8375378 [details] [diff] [review]
Updated patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 646359
User impact if declined: Possible hangs with large text files containing bidirectional text
Testing completed (on m-c, etc.): baked on m-c since 2014-02-18
Risk to taking this patch (and alternatives if risky): Should be minimal risk
String or IDL/UUID changes made by this patch: N/A

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a19e2d114ebd
https://hg.mozilla.org/releases/mozilla-beta/rev/7ef609d31ddf

Comment 12

[Ryan VanderMeulen [:RyanVM]]

And a follow-up because nsTextFrame.h wasn't actually included in the files where the new state bit was being used :)

https://hg.mozilla.org/releases/mozilla-aurora/rev/1888bbfc5726
https://hg.mozilla.org/releases/mozilla-beta/rev/5d2d60f3cb37

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/7ef609d31ddf
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/5d2d60f3cb37

Comment 14

[Ada [:adalucinet]]

Reproduced with Nightly from 2014-01-20 by using STR from comment 0.
Verified as fixed with Firefox 28 beta 9 (Build ID: 20140306171728) on Windows 7 64bit:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0

Comment 15

[Paul Silaghi, QA [:pauly]]

Verified fixed 29.0a2 (2014-03-10), 30.0a1 (2014-03-09) Win 7 x64.