964374 - browser_webconsole_view_source.js leaks after shutdown while running debug browser-chrome tests per directory

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am running debug browser-chrome tests per directory (not as a single chunk), and I get a large leak while running browser/devtools/webconsole/test.  

This leak is not made up, Try server even reports it!
https://tbpl.mozilla.org/?tree=Try&rev=b561d98e8d72

It gets better, you can download the build/tests from try server and run them locally to see this on your own machine.  I did that and after a game of whack-a-mole, the winning ticket is issued to browser_webconsole_view_source.js.  This file once removed from the file system and running the tests again with --test-path=browser/devtools/webconsole/test yields no leaks as per the mochitest harness.  

* caveat: this was run on linux64 ubuntu- other operating systems might yield different leak patterns, although try server yields similar log files.

Comment 1

[Mihai Sucan [:msucan]]

Mike landed some test fixes in bug 663778 which includes changes to this test as well. Do you still get the memleaks now?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

let me push to try- I just updated my patches last night and I can remove my skip-ifs in the webconsole bits.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I am not seeing this as a problem, I have removed it from my patch queue:
https://tbpl.mozilla.org/?tree=Try&rev=29bcc82f7302

Comment 4

[Mihai Sucan [:msucan]]

Then we can mark the bug as fixed. Please reopen if you find otherwise.