964438 - Update mozharness scripts with new marionette errors

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: update with new strings

After Bug 959520 lands, ahal pointed out that the new error reporting lines should be added to our mozharness scripts (https://hg.mozilla.org/integration/mozilla-inbound/rev/a37e6c57ae0f)

There are 2 lines to be added, and we should keep the old one for tests running against older branches.

Comment 1

[Aki Sasaki (not active)]

Comment on attachment 8366193 [details] [diff] [review]
update with new strings

'substr' is a substring; it runs an |if SUBSTR in STRING:|  Periods are periods here.
http://hg.mozilla.org/build/mozharness/file/35223f92c123/mozharness/base/log.py#l161

'regex' runs a re.compile()d regular expression.  Periods are single-character wildcards here.

In this case, the backslashes will cause the messages to not match.  r=me without the backslashes.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: update with new strings

Thanks, I didn't know that!

I've updated the patch and will land after the related bug lands.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Totally forgot about this after the bug landed, heh. Just to be sure, am I free to land this? It still applies cleanly.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

clearing needinfo, jgriffin approves :)

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

pushed to mozharness:
https://hg.mozilla.org/build/mozharness/rev/b6acd64fcf06