964510 - Add a browser-delayed-startup-finished notification

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We can fire something after the first page has loaded and move non-critical startup stuff there.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8366284 [details] [diff] [review]
Patch v1

If this function/handler gets anymore code in it we should make it a "real" method of BrowserApp. Fine for now as it is.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/58d9759ff3d1

Comment 4

[Carsten Book [:Tomcat]]

Hi, sorry backedout as part of https://tbpl.mozilla.org/?tree=Fx-Team&rev=c15e29ead092 for the suspicion of causing robocop testfailures on android like https://tbpl.mozilla.org/php/getParsedLog.php?id=33734468&tree=Fx-Team

Comment 5

[Wesley Johnston (:wesj)]

Attachment: af74d0fd42e1

Same exact patch, but also fires a notification to Java for delayed startup.

Comment 6

[Wesley Johnston (:wesj)]

Try looked good. back in:
https://hg.mozilla.org/integration/fx-team/rev/b8c9dc39af31

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b8c9dc39af31

Comment 8

[Wesley Johnston (:wesj)]

backed out for startup regressions:
https://hg.mozilla.org/integration/fx-team/rev/c80398db6447

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 8369089 [details] [diff] [review]
af74d0fd42e1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This caused a startup regression. I'd actually like to uplift the backout.
User impact if declined: Startup regression. Yeah that makes no sense.
Testing completed (on m-c, etc.): Has been on central. Seemed to help eideticker.
Risk to taking this patch (and alternatives if risky): Low risk. A Backout
String or IDL/UUID changes made by this patch: none.

Comment 10

[Wesley Johnston (:wesj)]

Relanding this on central actually. This SHOULD have no affect on startup by itself. Then we can layer on other pieces slowly.

https://hg.mozilla.org/integration/fx-team/rev/79bc2b2768e4

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/79bc2b2768e4

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Should the milestone be 29 here? It seems like the backout did not get uplifted.