964544 - Write Gaia-ui accessibility tests for the dialer app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now there's a pull request for dialer accessibility that is missing the gaia ui tests. Those must be added asap.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Patch for 964544

These are unit tests for changes in the pull request for Bug 923139.

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 8369650 [details] [review]
Patch for 964544

I'm not qualified to review this, redirecting to Zac.

Comment 3

[Zac C (:zac)]

Comment on attachment 8369650 [details] [review]
Patch for 964544

r- hi Yura, that's a very thorough and good start.

I gave it a very quick review and I think there are a lot of redundant steps that can possibly be removed and after that it will be ready to give it a thorough review.

It is really a good practice to have as few HTML locators as possible. If there are steps and locators that are redundant, or perhaps two can be merged into one, then that is a good tactic. This reduces the exposure to changes in the HTML that developers make and keeps our coverage alive for longer.

One test is failing on Travis too (you can see from Github). I also ran it on my Hamachi device and I got these two failures. They all need to be resolved before we can merge it.

r? me again after you have fixed up these changes!


test_phone_call_log (test_a11y_phone_call_log.TestAccessibilityPhoneCallLog) ... FAIL

======================================================================
FAIL: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zac/.virtualenvs/a11y/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/phone/test_a11y_phone_call_log.py", line 31, in test_phone_call_log
    *self.phone.call_log._call_log_edit_button_locator)))
TEST-UNEXPECTED-FAIL | test_a11y_phone_call_log.py test_a11y_phone_call_log.TestAccessibilityPhoneCallLog.test_phone_call_log | AssertionError: False is not true
----------------------------------------------------------------------
Ran 1 test in 50.579s

FAILED (failures=1)
test_phone_keypad (test_a11y_phone_keypad.TestAccessibilityPhoneKeypad) ... FAIL

======================================================================
FAIL: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zac/.virtualenvs/a11y/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/zac/Mozilla/gaia/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/phone/test_a11y_phone_keypad.py", line 29, in test_phone_keypad
    *self.phone.keypad._add_new_contact_button_locator)))
TEST-UNEXPECTED-FAIL | test_a11y_phone_keypad.py test_a11y_phone_keypad.TestAccessibilityPhoneKeypad.test_phone_keypad | AssertionError: False is not true
----------------------------------------------------------------------
Ran 1 test in 48.767s

FAILED (failures=1)

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Updated the tests and took care of your comments.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Rebased and Travis is green :)

Comment 6

[Zac C (:zac)]

Comment on attachment 8369650 [details] [review]
Patch for 964544

The tests run excellently on device and on Travis!

Comment 7

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/8ec594f1ebfb9710e670463abe80a631de4572c5