Closed Bug 964583 Opened 6 years ago Closed 4 years ago

change Web IDL [EnforceRange] (unsigned) long long boundary conditions to match ES6

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: heycam, Assigned: jdai, Mentored)

Details

(Whiteboard: [tw-dom] btpp-active)

Attachments

(2 files, 1 obsolete file)

With apologies to the patch writer in bug 891537, Web IDL has changed its handling of the boundaries of allowable values in (unsigned) long long to align with ES6.

https://github.com/heycam/webidl/commit/c569851a755f7e51f53ec7b751f2aaaa08abbd4a

https://www.w3.org/Bugs/Public/show_bug.cgi?id=24241
I would like to try on this bug.
Assignee: nobody → jdai
I've manually verified in my local.
Hi Boris, may I have your review? Thank you.
Attachment #8742732 - Flags: review?(bzbarsky)
Whiteboard: [tw-dom] → [tw-dom] btpp-active
Comment on attachment 8742732 [details] [diff] [review]
Bug 964583 - Revert Web IDL [EnforceRange] (unsigned) long long boundary conditions to match ES6.

r=me

Don't forget to set checkin-needed, or let me know if you can't do that yourself.
Attachment #8742732 - Flags: review?(bzbarsky) → review+
Comment on attachment 8743201 [details] [diff] [review]
Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. r=bz

Ah, excellent.  Test coverage!  ;)

r=me.
Attachment #8743201 - Flags: review?(bzbarsky) → review+
Attachment #8743201 - Attachment description: Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. → Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/06f1de1a5f2a
https://hg.mozilla.org/mozilla-central/rev/4b0df739e593
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.