Closed
Bug 964583
Opened 10 years ago
Closed 8 years ago
change Web IDL [EnforceRange] (unsigned) long long boundary conditions to match ES6
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: heycam, Assigned: jdai, Mentored)
Details
(Whiteboard: [tw-dom] btpp-active)
Attachments
(2 files, 1 obsolete file)
1.14 KB,
patch
|
jdai
:
review+
|
Details | Diff | Splinter Review |
943 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
With apologies to the patch writer in bug 891537, Web IDL has changed its handling of the boundaries of allowable values in (unsigned) long long to align with ES6. https://github.com/heycam/webidl/commit/c569851a755f7e51f53ec7b751f2aaaa08abbd4a https://www.w3.org/Bugs/Public/show_bug.cgi?id=24241
Whiteboard: [tw-dom]
Mentor: bzbarsky
Assignee | ||
Comment 2•8 years ago
|
||
I've manually verified in my local. Hi Boris, may I have your review? Thank you.
Attachment #8742732 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Whiteboard: [tw-dom] → [tw-dom] btpp-active
Comment 3•8 years ago
|
||
Comment on attachment 8742732 [details] [diff] [review] Bug 964583 - Revert Web IDL [EnforceRange] (unsigned) long long boundary conditions to match ES6. r=me Don't forget to set checkin-needed, or let me know if you can't do that yourself.
Attachment #8742732 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Carry on r+.
Attachment #8742732 -
Attachment is obsolete: true
Attachment #8743199 -
Flags: review+
Assignee | ||
Comment 5•8 years ago
|
||
I found out I hit an indexDB web-platform-test. Hi Boris, may I have your review? Thank you. Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b620be8041763597cf457824d71e5225a0d7762c
Attachment #8743201 -
Flags: review?(bzbarsky)
Comment 6•8 years ago
|
||
Comment on attachment 8743201 [details] [diff] [review] Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. r=bz Ah, excellent. Test coverage! ;) r=me.
Attachment #8743201 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8743201 -
Attachment description: Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. → Part 2: Bug 964583 - Update web-platform tests for Web IDL [EnforceRange] (unsigned) long long boundary conditions. r=bz
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/06f1de1a5f2a https://hg.mozilla.org/integration/mozilla-inbound/rev/4b0df739e593
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/06f1de1a5f2a https://hg.mozilla.org/mozilla-central/rev/4b0df739e593
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•