964771 - Add GA Event for Thimble Publish

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[David Humphrey (:humph)]

We want to start experimenting with GA Events, and are going to use Thimble as a test case to figure out the process.

Comment 1

[David Humphrey (:humph)]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/348

This adds GA Event tracking to Thimble using our shiny new webmaker-analytics module.

Adam, see if you're happy with the event name.  Also, do you care about success vs. failure cases (e.g., do you want me to log an event for publish-error)?

Pomax, is this the best place to log the event?

Comment 2

[Pomax]

Comment on attachment 8368576 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/348

looks fine to me, let's give this a shot.

Comment 3

[Adam Lofting (:adamlofting)]

Humph, that looks great.

If we can add tracking to publish-error, that gives us a good example of a nonInteraction event to showcase next week:

e.g. 
analytics.event("Error", {label: "Error Publishing", nonInteraction: true});

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/a0882f9813614cd6ea87e6d2c861464fd1bd35f7
Fix Bug 964771: Add GA Event for Thimble Publish

Comment 5

[David Humphrey (:humph)]

Adam, I've built this code on our staging infrastructure (thimble.mofostaging.net) and just published something.  Can you confirm that you get the "Publish" event for "thimble.mofostaging.net"?

If you did, I can push this up to production.

Comment 6

[Adam Lofting (:adamlofting)]

No luck yet because of the way GA data works...

I can see the Events being recorded in real-time if I'm looking at the dashboard straight away.

Otherwise they take 24 hours to be processed into the main reports.

I tried to do a publish myself from test staging site just now, but nothing happens if I click login, which means I can't get to the publish button. I'm online for a bit and happy to keep an eye on the real-time reports if anyone can click the publish button on staging? :)

Comment 7

[Adam Lofting (:adamlofting)]

Good news, these events have already made it through to the main reports so I can confirm they are being recorded correctly.

It's ready to go.

Thanks! :)