964776 - [Flatfish][Settings] No vibrating alert motor, "Vibrate" option should be removed from Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chang [:ericcc] [:echang]]

GAIA commit e314d089d988f0eb1bef2404858c60b734dc4130

$GAIA_DISTRIBUTION_DIR=distribution_tablet make reset-gaia

1. Open "Settings" -> "Sound"
2. <ISSUE> "Vibrate" existed.

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: SettingsSound.png

Comment 2

[Francis Lee [:frlee]]

flatfish doesn't support Vibration from HW perspective, so vibrate option needs to be removed from setting.

Comment 3

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Is this bug anyway related to the Tablet Contribution Program?

Comment 4

[yifan [:yifan][:yliao]]

Settings app uses API to check for device functionality support, and show/hide the corresponding setting items relatively.

For vibration, it seems there isn't an API that could do it.
https://developer.mozilla.org/en-US/docs/Web/API/Navigator.vibrate
http://www.w3.org/TR/vibration/#vibration-interface
navigator.vibrate() does nothing when a device doesn't support vibration and it still returns true.

Tried it on flatfish. Any ideas on checking for device vibration support?

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

For feature detection that is not well supported in gecko, a workaround would be using a json file. There is a similar case in settings app where we are unable to detect if the light sensor is available on the device. We added a sensors.json in the end. Please check https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide for details.

Comment 6

[yifan [:yifan][:yliao]]

Thank you! I assume that means we would need to create another json such as vibrator.json for this, or simply put a key value pair for vibration support in sensors.json. What's your suggestion on it?

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

As this is actually a rare case, I would prefer placing it in the same file but rename it with a more general name.

Comment 8

[yifan [:yifan][:yliao]]

How about device-features.json? Should we open another bug to make the naming change and then come back to this one?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

The name is good to me. I think doing the rename in this bug is fine.

Comment 10

[yifan [:yifan][:yliao]]

Attachment: pull request

Modifications:

* Rename customization/sensors.json to customization/device-features.json
* Modify build.js to replace sensors.json with device-features.json
* Show/Hide 'Vibrate' checkbox according to the 'vibration' value in device-features.json
* Update .gitignore and integration test

Once it's landed, I will update the documentations as well. I found these 2 relevant links.
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide#sensors.json
https://wiki.mozilla.org/FirefoxOS/TCP/Patching#Start_to_build_flatfish

Customization example, same applies to devices without vibration support:
1. Create a customization folder with device-features.json in it.
2. Code {"vibration":false} in device-featrues.json for flatfish.
3. Add GAIA_DISTRIBUTION_DIR=<customization-path> when building gaia for flatfish.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8472782 [details] [review]
pull request

Good job! Thank you for taking the effort. r=me with the comment addressed.

Comment 12

[yifan [:yifan][:yliao]]

Thank you! Console logs removed.

Merged into master
https://github.com/mozilla-b2g/gaia/pull/22861

TBPL
https://tbpl.mozilla.org/?rev=430912076404fb503fb1402728b0dbc2fc3c93d1&tree=Gaia-Try

MDN updated
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Market_customizations_guide#device-features.json