It should store all language preferences in Exact Target for future use and analytics.
One question I have on this is whether the language column in Exact Target can store only 2 characters, or 5 for things like "pt-BR"?
The "LANGUAGE_ISO2" field in "Master_Subscribers" can hold up to 5 characters; however - if we pass through more than just the 2, I have to search for "contains en" instead of "is en" (which I currently do for the languages). This works well for now with a limited number of possible locales that are passed through to ExactTarget. If we start collecting any/all locales, I'm curious how many other languages have country codes that might mess with the "contains" query. I can't think of any off the top of my head other than "es-ES" - but that would be Spanish no matter the query. Can you think of other locale combos that could/would mess up segmenting overall language?
(In reply to Jessilyn Davis from comment #2) > This works well for now with a limited number of possible locales that are > passed through to ExactTarget. If we start collecting any/all locales, I'm > curious how many other languages have country codes that might mess with the > "contains" query. I can't think of any off the top of my head other than > "es-ES" - but that would be Spanish no matter the query. > > Can you think of other locale combos that could/would mess up segmenting > overall language? I can't think of any, but that doesn't mean they don't exist. How hard would it be to do a "starts with" query instead of a "contains"? That's the real answer. In SQL proper it would just be "WHERE LANGUAGE_ISO2 LIKE 'es%';" or something like that. Hopefully ET makes that kind of thing easy. It would be nice to collect the full thing since things like zh-TW and zh-CN are quite different I believe.
"starts with" (aka "begins with" in ExcactTarget's Filters) works! Good call. Let's pass through the full 5 characters! For my notes: * For EN we'll make it "starts with EN" or "is blank" * All the other current newsletter languages should be good to filter with "starts with") * As we launch other languages, we'll adapt how to best filter and segment.
Assignee: nobody → pmac
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/basket https://github.com/mozilla/basket/commit/0a8661bee542138140fbd319b9304681aef1895b Fix bug 964848: Accept all properly formatted language codes. https://github.com/mozilla/basket/commit/bc14fa0e15729b3ec85f6d49c274d3e053b68d7c Merge pull request #94 from pmclanahan/store-all-lang-prefs-964848 Fix bug 964848: Accept all properly formatted language codes.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Thanks pmac! \o/ Mike - do you know who can make an API call to basket with language = it and can let me know what unique email address they used? I can then check ExactTarget to make sure their info was passed through correctly with a non-newsletter supported language and verify this bug. Thanks!
Pmac - this needs to be fixed for the OS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=964342#c39 When using an es-PE (Spanish + Peru) combo, the OS signup form did not work. When using DE (German + Germany) it worked beautifully. What's the next steps to make this work with the OS FTU form?
Just need to do a prod push. I can get on that whenever we're ready.
Prod push happened in Bug 977201 Pmac tested and verified via IRC that these scenarios worked: es-PE (peru) en-US de
Status: RESOLVED → VERIFIED
Depends on: 977201
You need to log in before you can comment on or make changes to this bug.