964902 - invalid assertions on xulrunner startup [XPCOM objects created/destroyed from static ctor/dtor]

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Noel Cragg]

Attachment: patch nsXULRunnerApp.cpp so it calls NS_LogInit()

+++ This bug was initially created as a clone of Bug #326837 +++

I built XULRunner from mozilla-central 4da3e21a0e5f and enabled debugging.  When running it (even on the example "simple" application), I got approximately 40 errors of this variety:

[84737] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /Users/noel/compile/mozilla-central/xpcom/base/nsTraceRefcntImpl.cpp, line 142

This appears to be the same issue as reported in bug 326837, but in nsXULRunnerApp.cpp (the XUL-equivalent file of nsAppRunner.cpp).

While I observed this behavior on x86_64-apple-darwin11.4.2, I would guess this also occurs on other platforms.

I made a patch consisting of modifications similar to bsmedberg's from 32837.  After applying those changes, the error messages disappeared.

Comment 1

[Stefan [:stefanh]]

Noel, you might want to ask bsmedberg to review your patch. Click the "Details" link next to attachment and then set the Review flag to "?" and enter bsmedbergs email address in the Requestee field (just entering "bsmedberg" should give you the option to pick the right address).

Comment 2

[Noel Cragg]

Comment on attachment 8366790 [details] [diff] [review]
patch nsXULRunnerApp.cpp so it calls NS_LogInit()

Thanks -- doing as you suggest, Stefan.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8366790 [details] [diff] [review]
patch nsXULRunnerApp.cpp so it calls NS_LogInit()

You don't actually need the ScopedLogging in the Usage() function because it's already wrapped in the main function. Once is enough, I think.

Comment 4

[Noel Cragg]

Attachment: make sure log is initialized in nsXULRunnerApp.cpp

Thanks for reviewing, bsmedberg.  I've removed the redundant declaration from Usage().

Comment 5

[Benjamin Smedberg]

Comment on attachment 8367542 [details] [diff] [review]
make sure log is initialized in nsXULRunnerApp.cpp

Thank you!

Comment 6

[Noel Cragg]

Sorry for the delay in adding the "checkin-needed" flag.  I have been told that since this patch is only for XUL, there's no use in committing it to the "try" repository because it will never get invoked by anything in that test harness.  Given the simplicity of the patch (and the fact that it fixes the problem in an almost identical way to the parallel problem from bug 326837), I'd argue that this is ready to be merged in.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80d2e397ed27

Thanks for the patch, Noel! One request, please make sure that future patches include proper commit information. Makes life much easier for those landing on your behalf :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 8

[Noel Cragg]

Ryan, thanks for the reference to that document.  I'm still trying to ramp up on all of the requirements and conventions!  I appreciate everyone being patient with me through this process.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80d2e397ed27