The desktop platform selection block is bigger than other platforms

VERIFIED FIXED in 2014-09-30

Status

Marketplace
Developer Pages
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: krupa, Assigned: mat)

Tracking

2014-09-30
Points:
---

Details

(Whiteboard: [cosmetic][contribute][repoman], URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8366859 [details]
screenshot

steps to reproduce:
1. Load https://marketplace.firefox.com/developers/app/test-app-tvfve/payments/
2. Notice the device options

observed behavior:
Desktop block is much bigger than the other platforms. See screenshot.
(Assignee)

Updated

4 years ago
Priority: -- → P5
(Reporter)

Updated

4 years ago
Duplicate of this bug: 975398

Updated

4 years ago
Whiteboard: [cosmetic]

Updated

4 years ago
Whiteboard: [cosmetic] → [cosmetic][contribute][repoman]
(Assignee)

Comment 2

4 years ago
Changing the text to "Firefox Desktop" would solve this (and work for everyone assuming we don't translate the string differently in other languages)
(Assignee)

Updated

4 years ago
Assignee: nobody → mpillard
Status: NEW → ASSIGNED

Comment 3

4 years ago
Also , please note that all selections from "Paid\In-app" section are bigger than the ones from Free section : http://screencast.com/t/uJhIJtawaS
(Assignee)

Updated

4 years ago
Assignee: mpillard → nobody
Status: ASSIGNED → NEW

Comment 4

4 years ago
This is as annoyingly as hell.
Priority: P5 → P2
(In reply to Andy McKay [:andym] from comment #4)
> This is as annoyingly as hell.

If I marked as P2 all the bugs that annoy me, every Marketplace bug would be a P2 :-P

I kid!
(Assignee)

Comment 6

4 years ago
This sounds like something that would easily solved without any weird hacks with using flexbox on the parent (and if the browser doesn't support it, so be it, it should degrade gracefully)
Flexbox is not a weird hack. We should get comfortable using it.

But you could just fix this by increasing the height of all of the other boxes.
(Assignee)

Comment 8

4 years ago
I'm saying that using flexbox would *not* be a weird hack, but any other solution probably would :)
My bad :) You have the right idea. Amen!
(Assignee)

Updated

4 years ago
Assignee: nobody → mpillard
(Assignee)

Comment 10

4 years ago
https://github.com/mozilla/zamboni/pull/2572
Status: NEW → ASSIGNED
(Assignee)

Comment 11

4 years ago
Fixed in https://github.com/mozilla/zamboni/commit/8dbd428918a8dbcc93b989b0a02d245cccc882b2

STR:
See comment 0, but also check app submission page, and in compatibility page, check both free & paid tabs (switching the app paid/free status as necessary).
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-09-30

Comment 12

4 years ago
Verified as fixed in https://marketplace-dev.allizom.org/ on FF35 (Win 7).
Postfix screencast http://screencast.com/t/OcAMOoCtLlN
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.