964962 - Talos - replace loadAboutBlank flag name and implementation with loadNoCache

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Avi Halachmi (:avih)]

Attachment: tploadblank-tploadnocache.patch

TART (bug 848358) and CART (bug 956388) reload the same chrome URI to re-trigger the test, but the initial default behavior didn't trigger the test when the page was reloaded.

To fix that, the patch on bug 848358 includes a flag loadAboutBlank which, whenever it needs to reload the page, first load about:blank, then setTimeout 0 to load the actual test-page.

This flag and behavior was rather hacky, so this bug is about replacing it with proper implementation which bypasses the cache (if the flag is set), which makes the page reload as it should, without the intermediate loading of about:blank.

Currently the flag (with the old/new name) is used only with TART and CART.

Note that the flag name already confused some developers in the past, so the name changing should also help with that.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8366860 [details] [diff] [review]
tploadblank-tploadnocache.patch

Review of attachment 8366860 [details] [diff] [review]:
-----------------------------------------------------------------

looks good!

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/cb7bcf1889aa