964964 - Try to remove window.pkcs11

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

It's been returning null since bug 326628 (Fx 3.0.14). Maybe sniffing code doesn't use it.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Remove window.pkcs11

https://tbpl.mozilla.org/?tree=Try&rev=289c747fbf2e

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8367352 [details] [diff] [review]
Remove window.pkcs11

Not it!

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8367352 [details] [diff] [review]
Remove window.pkcs11

Need to rev nsIDOMWindow IID.

r=me with that, but be _very_ careful of object-sniffing bogosity on sites.  :(

Comment 4

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c57cf5f7cc48

Comment 5

[j.j.]

(In reply to :Ms2ger from comment #0)
> Maybe sniffing code doesn't use it.

It was somewhat (not much) popular in Germany because recommended here:
http://www.lipfert-malik.de/webdesign/tutorial/bsp/browser_js_test.html
© K.Lipfert Düsseldorf 2002-2008

Haven't seen it recently, but heads up if there are regressions on German sites please.

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to j.j. (mostly inactive) from comment #5)
> (In reply to :Ms2ger from comment #0)
> > Maybe sniffing code doesn't use it.
> 
> It was somewhat (not much) popular in Germany because recommended here:
> http://www.lipfert-malik.de/webdesign/tutorial/bsp/browser_js_test.html
> © K.Lipfert Düsseldorf 2002-2008
> 
> Haven't seen it recently, but heads up if there are regressions on German
> sites please.

Don't worry. The check |if(window.pkcs11)| is already broken because window.pkcs11 will return a falsy value (null) since Firefox 3.0.14.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c57cf5f7cc48

Comment 8

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Web/API/Window
https://developer.mozilla.org/en-US/docs/Web/API/Window.pkcs11
https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility