964995 - Australis - Legacy button not positioned correctly in Australis overflow panel

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Screenshot of problem

Similar to bug 942144, toolbaritems that contain a toolbarbutton do not display correctly in the overflow panel displayed by the chevron.

Comment 1

[:Gijs (he/him)]

All things considered, I don't think it looks that bad, really... Like, it can be improved, but it's not as terrible as it could be.

Comment 2

[:Gijs (he/him)]

Is this still an issue?

Comment 3

[Mike Kaply [:mkaply]]

(In reply to :Gijs Kruitbosch from comment #2)
> Is this still an issue?

Yes, it's the same as before.

It's functional, but it doesn't look like any other buttons (the border is smaller).

I still believe that the CSS rules for the overflow panel need to be updated so they affect any toolbarbutton-1 descendents, not just toolbarbuttons that are children of the panel.

Comment 4

[:Gijs (he/him)]

(In reply to Mike Kaply (:mkaply) from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > Is this still an issue?
> 
> Yes, it's the same as before.
> 
> It's functional, but it doesn't look like any other buttons (the border is
> smaller).
> 
> I still believe that the CSS rules for the overflow panel need to be updated
> so they affect any toolbarbutton-1 descendents, not just toolbarbuttons that
> are children of the panel.

I think I did this in bug 971956. It'd be useful if you could test what remains to be done here with a build that includes the fix from that bug.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Current Screenshot

It looks way better. Great job.

The only remaining issue would be that the button (and hence the hover effect) doesn't extend all the way across the panel like it does with the other buttons.

But I could live with that.

Comment 6

[:Gijs (he/him)]

No more legacy, no more hamburger panel grid, no more bug.