Closed Bug 964995 Opened 7 years ago Closed 3 years ago

Australis - Legacy button not positioned correctly in Australis overflow panel

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mkaply, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P5])

Attachments

(2 files)

Attached image Screenshot of problem
Similar to bug 942144, toolbaritems that contain a toolbarbutton do not display correctly in the overflow panel displayed by the chevron.
All things considered, I don't think it looks that bad, really... Like, it can be improved, but it's not as terrible as it could be.
See Also: → 942144
Whiteboard: [Australis:P5]
Is this still an issue?
Flags: needinfo?(mozilla)
(In reply to :Gijs Kruitbosch from comment #2)
> Is this still an issue?

Yes, it's the same as before.

It's functional, but it doesn't look like any other buttons (the border is smaller).

I still believe that the CSS rules for the overflow panel need to be updated so they affect any toolbarbutton-1 descendents, not just toolbarbuttons that are children of the panel.
Flags: needinfo?(mozilla)
(In reply to Mike Kaply (:mkaply) from comment #3)
> (In reply to :Gijs Kruitbosch from comment #2)
> > Is this still an issue?
> 
> Yes, it's the same as before.
> 
> It's functional, but it doesn't look like any other buttons (the border is
> smaller).
> 
> I still believe that the CSS rules for the overflow panel need to be updated
> so they affect any toolbarbutton-1 descendents, not just toolbarbuttons that
> are children of the panel.

I think I did this in bug 971956. It'd be useful if you could test what remains to be done here with a build that includes the fix from that bug.
Depends on: 971956
Flags: needinfo?(mozilla)
Attached image Current Screenshot
It looks way better. Great job.

The only remaining issue would be that the button (and hence the hover effect) doesn't extend all the way across the panel like it does with the other buttons.

But I could live with that.
Flags: needinfo?(mozilla)
No more legacy, no more hamburger panel grid, no more bug.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.