Closed
Bug 965017
Opened 11 years ago
Closed 11 years ago
Remove session restore shutdown handling
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
|
5.61 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
We removed the shutdown notification from onDestroy back in bug 823285 (see https://bugzilla.mozilla.org/show_bug.cgi?id=823285#c21). The reason is that they were unreliable as OOM kills and force quits did not trigger these shutdown notifications.
Because shutdown notifications aren't fired on Android, the shutdown handling code in SessionStore.js is just dead code that we can remove.
|
||
Comment 1•11 years ago
|
||
Gingerbread still supports "Quit" and add-ons could add it back. Thoughts?
|
Assignee | |
Comment 2•11 years ago
|
||
We could go even further and remove the "domwindowclosed" handler, but I kept it in case we ever add functionality to close windows (even though it probably doesn't even work properly as-is). Happy to remove it if you prefer.
Attachment #8366952 -
Flags: review?(mark.finkle)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8366952 [details] [diff] [review]
Remove session restore shutdown handling
I'm convinced that "shutdown" on Android is a fallacy.
Attachment #8366952 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•