965045 - Always use https: protocol when embedding youtube videos

Status: RESOLVED FIXED

(Webmaker Graveyard :: popcorn.js, defect)

Description

[Jon Buckley [:jbuck]]

https://github.com/mozilla/popcorn-js/blob/master/wrappers/youtube/popcorn.HTMLYouTubeVideoElement.js#L24 needs to be an https: URL instead of a protocol-less ("//") URL.

Comment 1

[Vick Makifina]

Hi Jon,

I would like the opportunity to fix this bug.

Thanks.

Comment 2

[Jon Buckley [:jbuck]]

Hi Makifina, thanks for taking this bug!

If you have any questions about how to fix this, feel free to ask here or on IRC in irc.mozilla.org #webmaker .

Comment 3

[Vick Makifina]

Hi John i have had issues with my bugzilla build, so i am reinstalling it, i will get back to fixing this soon,

Thanks.

Comment 4

[Zulfa]

Hi John
I want to take this bug as my first contribution to Mozilla, can you assign me to it?, and as this is my first bug. I would like you to point to me where to start, or any suggestion will be much appreciated.

Thanks.

Comment 5

[Jon Buckley [:jbuck]]

Hi Zulfa, Makifina is already working on this bug. If you'd like to work on some other mentored bugs, take a look at the list of unassigned mentor bugs: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=prod%3Awebmaker assigned%3Anobody%40mozilla.org whiteboard%3Amentor

Comment 6

[Jon Buckley [:jbuck]]

Sorry, that search should be https://bugzilla.mozilla.org/buglist.cgi?quicksearch=prod%3Awebmaker%20assigned%3Anobody%40mozilla.org%20whiteboard%3Amentor

Comment 7

[Jon Buckley [:jbuck]]

Scott fixed this in https://github.com/mozilla/popcorn-js/commit/4fe23b3d94e7b8f9e4a1948894a86753ff7f6644