Closed
Bug 965048
Opened 10 years ago
Closed 10 years ago
Always use https: protocol when embedding soundcloud audio
Categories
(Webmaker Graveyard :: popcorn.js, defect)
Webmaker Graveyard
popcorn.js
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: admix)
References
Details
(Whiteboard: [mentor=jbuck][goodfirstbug])
Attachments
(1 file)
https://github.com/mozilla/popcorn-js/blob/master/wrappers/soundcloud/popcorn.HTMLSoundCloudAudioElement.js#L16-L17 needs to be an https: URL instead of a protocol-less ("//") URL.
|
Assignee | |
Comment 1•10 years ago
|
||
Hey Jon, can you assign this one to me plz. Thanks.
|
Reporter | |
Updated•10 years ago
|
Assignee: nobody → admix.snurnikov
|
|
Reporter | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://github.com/mozilla/popcorn-js/pull/376
Attachment #8369801 -
Flags: review?(jon)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8369801 -
Flags: review?(jon) → review+
|
||
Comment 3•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn-js https://github.com/mozilla/popcorn-js/commit/3f55c1eb1925c1e8a8bbcfac7735b35be2793db6 [bug965048] - Fixed protocol to 'https' when embedding soundcloud audios
|
|
Reporter | |
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 4•10 years ago
|
||
Don't forget you need a submodule update!
You need to log in
before you can comment on or make changes to this bug.
Description
•